Create a 'webrtc_nonparallel_tests' target.

Create a 'webrtc_nonparallel_tests' target.

Used for tests that cannot be run in parallel due to using non-virtual
resources such as filesystems and sockets. Initially moves socket
unittests from rtc_unittest since
PhysicalSocketTest.TestUdpReadyToSendIPv4 is one of the worst flake
offenders.

Future prospect targets are GTEST_DEATH tests that are flaky on Mac in
parallel for instance.

BUG=chromium:445880
R=kjellander@webrtc.org

Committed: https://crrev.com/95192fbb1ebf4f402654b43b9b3ac215d3ef0481
Cr-Commit-Position: refs/heads/master@{#10446}

[pbos-webrtc, 2015-10-28 15:28:12]

PTAL, I hope this building is enough to add it. I compiled and ran it locally on
Linux at least. Woo. :)

[pbos-webrtc, 2015-10-28 15:35:43]

add CARBON_DEPRECATED

[pbos-webrtc, 2015-10-28 15:36:25]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-28 15:36:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426643003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426643003/20001

[commit-bot: I haz the power, 2015-10-28 15:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 15:37:58]

Dry run: Try jobs failed on following builders:
  win_x64_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/4804)

[pbos-webrtc, 2015-10-28 15:42:53]

use test_support instead of test_support_main

[kjellander_webrtc, 2015-10-28 15:53:42]

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/base/base_tests.gyp
File webrtc/base/base_tests.gyp (right):

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/base/base_tests.gy...
webrtc/base/base_tests.gyp:130: # TODO(ronghuawu): Fix TestUdpReadyToSendIPv6 on
windows bot
Remove this TODO.

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (right):

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/webrtc_tests.gypi#...
webrtc/webrtc_tests.gypi:268: 'base/physicalsocketserver_unittest.cc',
I don't remember if there's anything stopping us from getting rid of these
include+exclude conditions.

Can you make it so the right sources are added for OS!="win", so they don't have
to be listed in the all-platforms sources listing above?

[pbos-webrtc, 2015-10-29 09:46:33]

PTAL

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/base/base_tests.gyp
File webrtc/base/base_tests.gyp (right):

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/base/base_tests.gy...
webrtc/base/base_tests.gyp:130: # TODO(ronghuawu): Fix TestUdpReadyToSendIPv6 on
windows bot
On 2015/10/28 15:53:42, kjellander (webrtc) wrote:
> Remove this TODO.

Done.

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (right):

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/webrtc_tests.gypi#...
webrtc/webrtc_tests.gypi:268: 'base/physicalsocketserver_unittest.cc',
On 2015/10/28 15:53:42, kjellander (webrtc) wrote:
> I don't remember if there's anything stopping us from getting rid of these
> include+exclude conditions.
> 
> Can you make it so the right sources are added for OS!="win", so they don't
have
> to be listed in the all-platforms sources listing above?

This one (!= win) is currently only here to disable tests for Windows, that's
why win32socketserver_unittest.cc is both added and removed in the same
condition block.

I think the tests should be disabled within ifdefs in the file itself, but can I
punt that? I put a TODO here.

[pbos-webrtc, 2015-10-29 09:46:44]

comments

[pbos-webrtc, 2015-10-29 09:47:00]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 09:47:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426643003/60001

[commit-bot: I haz the power, 2015-10-29 11:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 11:13:29]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2015-10-29 11:30:17]

lgtm

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (right):

https://codereview.webrtc.org/1426643003/diff/40001/webrtc/webrtc_tests.gypi#...
webrtc/webrtc_tests.gypi:268: 'base/physicalsocketserver_unittest.cc',
On 2015/10/29 09:46:33, pbos-webrtc wrote:
> On 2015/10/28 15:53:42, kjellander (webrtc) wrote:
> > I don't remember if there's anything stopping us from getting rid of these
> > include+exclude conditions.
> > 
> > Can you make it so the right sources are added for OS!="win", so they don't
> have
> > to be listed in the all-platforms sources listing above?
> 
> This one (!= win) is currently only here to disable tests for Windows, that's
> why win32socketserver_unittest.cc is both added and removed in the same
> condition block.
> 
> I think the tests should be disabled within ifdefs in the file itself, but can
I
> punt that? I put a TODO here.

What I meant is that these files could be removed from the all-platforms source
block above and have this sources! block changed to a sources block put under a
OS!="win" condition instead.
Then each file would only be listed once. But it's fine to do that in another CL
(since there are many more places it can be done).

[pbos-webrtc, 2015-10-29 11:41:28]

Description was changed from

==========
Create a 'webrtc_nonparallel_tests' target.

Used for tests that cannot be run in parallel due to using non-virtual
resources such as filesystems and sockets. Initially moves socket
unittests from rtc_unittest since
PhysicalSocketTest.TestUdpReadyToSendIPv4 is one of the worst flake
offenders.

Future prospect targets are GTEST_DEATH tests that are flaky on Mac in
parallel for instance.

BUG=chromium:445880
R=kjellander@webrtc.org
==========

to

==========
Create a 'webrtc_nonparallel_tests' target.

Used for tests that cannot be run in parallel due to using non-virtual
resources such as filesystems and sockets. Initially moves socket
unittests from rtc_unittest since
PhysicalSocketTest.TestUdpReadyToSendIPv4 is one of the worst flake
offenders.

Future prospect targets are GTEST_DEATH tests that are flaky on Mac in
parallel for instance.

BUG=chromium:445880
R=kjellander@webrtc.org
TBR=
==========

[pbos-webrtc, 2015-10-29 11:41:51]

Adding an empty TBR= because webrtc/base/OWNERS should have an exclusion for gyp
files like other OWNERS files.

[pbos-webrtc, 2015-10-29 11:42:11]

Committed patchset #4 (id:60001) manually as
95192fbb1ebf4f402654b43b9b3ac215d3ef0481 (presubmit successful).

[commit-bot: I haz the power, 2015-10-29 11:42:16]

Patchset 4 (id:??) landed as
https://crrev.com/95192fbb1ebf4f402654b43b9b3ac215d3ef0481
Cr-Commit-Position: refs/heads/master@{#10446}

[kjellander_webrtc, 2015-10-29 14:13:42]

I failed to remember that there's more work needed for this target. See
https://codereview.webrtc.org/1409803007/ for additional files that needs to be
updated.

[pbos-webrtc, 2015-10-29 14:23:46]

On 2015/10/29 14:13:42, kjellander (webrtc) wrote:
> I failed to remember that there's more work needed for this target. See
> https://codereview.webrtc.org/1409803007/ for additional files that needs to
be
> updated.

Wow this is really not very DRY. *wah wah*

https://codereview.webrtc.org/1419023003/

:)