Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1426103005: Fixed window capute may end when window's full screen mode switchs on/off (Closed)

Created:
5 years, 1 month ago by GeorgeZ
Modified:
5 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

If a desktop captured window switches on/off it full screen mode, the capture may be unexpectedly terminated. During the transition of full screen mode on/off, the window can be temporarily invisible. BUG=498484 Committed: https://crrev.com/c94bd9bf86d39b2b17ffaad0775d28e875f24b08 Cr-Commit-Position: refs/heads/master@{#10583}

Patch Set 1 #

Total comments: 2

Patch Set 2 : change base on reviewer's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M webrtc/modules/desktop_capture/window_capturer_win.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
GeorgeZ
Sergey, Would you please have a review for me. Thanks, George
5 years, 1 month ago (2015-11-04 23:42:23 UTC) #3
GeorgeZ
On 2015/11/04 23:42:23, GeorgeZ wrote: > Sergey, > > Would you please have a review ...
5 years, 1 month ago (2015-11-09 20:57:19 UTC) #4
Sergey Ulanov
lgtm https://codereview.webrtc.org/1426103005/diff/1/webrtc/modules/desktop_capture/window_capturer_win.cc File webrtc/modules/desktop_capture/window_capturer_win.cc (right): https://codereview.webrtc.org/1426103005/diff/1/webrtc/modules/desktop_capture/window_capturer_win.cc#newcode166 webrtc/modules/desktop_capture/window_capturer_win.cc:166: // on Mac, or if window is invisible. ...
5 years, 1 month ago (2015-11-09 21:27:40 UTC) #5
GeorgeZ
https://codereview.webrtc.org/1426103005/diff/1/webrtc/modules/desktop_capture/window_capturer_win.cc File webrtc/modules/desktop_capture/window_capturer_win.cc (right): https://codereview.webrtc.org/1426103005/diff/1/webrtc/modules/desktop_capture/window_capturer_win.cc#newcode166 webrtc/modules/desktop_capture/window_capturer_win.cc:166: // on Mac, or if window is invisible. Window ...
5 years, 1 month ago (2015-11-09 21:59:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426103005/20001
5 years, 1 month ago (2015-11-09 21:59:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-09 23:59:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426103005/20001
5 years, 1 month ago (2015-11-10 15:30:07 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 15:33:55 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 15:34:06 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c94bd9bf86d39b2b17ffaad0775d28e875f24b08
Cr-Commit-Position: refs/heads/master@{#10583}

Powered by Google App Engine
This is Rietveld 408576698