Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1425613004: Remove VIDEOCODEC_* from engine_configurations.h. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VIDEOCODEC_* from engine_configurations.h. Removes index-based codec fetching from the VCM and overall cleans up the code. BUG=webrtc:1695 R=mflodman@webrtc.org Committed: https://crrev.com/92f8dbde77f859449a2b9ac107bca6c9b4329897 Cr-Commit-Position: refs/heads/master@{#10770}

Patch Set 1 #

Patch Set 2 : remove comment part #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -158 lines) Patch
M webrtc/engine_configurations.h View 1 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/main/interface/video_coding.h View 1 chunk +0 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.h View 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 7 chunks +16 lines, -66 lines 0 comments Download
M webrtc/modules/video_coding/main/source/internal_defines.h View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_coding_impl.cc View 1 1 chunk +2 lines, -15 lines 1 comment Download
M webrtc/video_engine/vie_encoder.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
pbos-webrtc
PTAL
5 years, 1 month ago (2015-11-06 13:05:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425613004/1
5 years, 1 month ago (2015-11-06 13:05:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 14:57:13 UTC) #5
pbos-webrtc
remove comment part
5 years, 1 month ago (2015-11-16 17:49:14 UTC) #6
pbos-webrtc
5 years, 1 month ago (2015-11-16 17:49:28 UTC) #7
mflodman
LGTM https://codereview.webrtc.org/1425613004/diff/20001/webrtc/modules/video_coding/main/source/video_coding_impl.cc File webrtc/modules/video_coding/main/source/video_coding_impl.cc (right): https://codereview.webrtc.org/1425613004/diff/20001/webrtc/modules/video_coding/main/source/video_coding_impl.cc#newcode312 webrtc/modules/video_coding/main/source/video_coding_impl.cc:312: int32_t VideoCodingModule::Codec(VideoCodecType codecType, VideoCodec* codec) { Add TODO() ...
5 years ago (2015-11-24 10:14:38 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/92f8dbde77f859449a2b9ac107bca6c9b4329897 Cr-Commit-Position: refs/heads/master@{#10770}
5 years ago (2015-11-24 12:56:10 UTC) #9
pbos-webrtc
5 years ago (2015-11-24 12:56:10 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
92f8dbde77f859449a2b9ac107bca6c9b4329897 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698