Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1425583002: Add GN Build file for rtc_sound target. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, Dirk Pranke, juberti2, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add GN Build file for rtc_sound target. Tested on Linux with the following command lines: $ gn gen out-gn/Release --args='is_debug=false target_cpu="x64" build_with_chromium=false' $ ninja -C out-gn/Release rtc_sound BUG=webrtc:4160 R=kjellander@webrtc.org Committed: https://crrev.com/f054819e257a4f9cbb7fa82ba51dc2335f4359ec Cr-Commit-Position: refs/heads/master@{#10405}

Patch Set 1 #

Total comments: 2

Patch Set 2 : webrtc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
A webrtc/sound/BUILD.gn View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
5 years, 2 months ago (2015-10-24 22:13:44 UTC) #1
kjellander_webrtc
Thanks for the contribution! https://codereview.webrtc.org/1425583002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.webrtc.org/1425583002/diff/1/BUILD.gn#newcode13 BUILD.gn:13: "//webrtc/sound:rtc_sound", Please put this into ...
5 years, 1 month ago (2015-10-25 18:48:28 UTC) #2
tfarina
https://codereview.webrtc.org/1425583002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.webrtc.org/1425583002/diff/1/BUILD.gn#newcode13 BUILD.gn:13: "//webrtc/sound:rtc_sound", On 2015/10/25 18:48:28, kjellander (webrtc) wrote: > Please ...
5 years, 1 month ago (2015-10-25 21:01:44 UTC) #3
kjellander_webrtc
lgtm!
5 years, 1 month ago (2015-10-26 04:19:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425583002/20001
5 years, 1 month ago (2015-10-26 12:14:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 12:15:31 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 12:15:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f054819e257a4f9cbb7fa82ba51dc2335f4359ec
Cr-Commit-Position: refs/heads/master@{#10405}

Powered by Google App Engine
This is Rietveld 408576698