Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1425533003: Fix chromium-style warnings in webrtc/sound/. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, juberti2, kjellander_chromium, pthatcher2, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix chromium-style warnings in webrtc/sound/. Tested on Linux with the following command lines: $ ./webrtc/build/gyp_webrtc -Dclang_use_chrome_plugins=1 $ ninja -C out/Release rtc_sound BUG=webrtc:163 R=perkj@webrtc.org Committed: https://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb Cr-Commit-Position: refs/heads/master@{#10447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -98 lines) Patch
M webrtc/sound/alsasoundsystem.h View 1 chunk +12 lines, -12 lines 0 comments Download
M webrtc/sound/alsasoundsystem.cc View 7 chunks +24 lines, -26 lines 0 comments Download
M webrtc/sound/nullsoundsystem.h View 1 chunk +12 lines, -12 lines 0 comments Download
M webrtc/sound/nullsoundsystem.cc View 2 chunks +14 lines, -17 lines 0 comments Download
M webrtc/sound/nullsoundsystemfactory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/sound/platformsoundsystemfactory.h View 1 chunk +3 lines, -5 lines 0 comments Download
M webrtc/sound/sound.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/sound/soundinputstreaminterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/sound/soundinputstreaminterface.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/sound/soundoutputstreaminterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/sound/soundoutputstreaminterface.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/sound/soundsystemproxy.h View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
PTAL.
5 years, 1 month ago (2015-10-28 17:55:56 UTC) #1
kwiberg-webrtc
lgtm I'm not familiar with this code (nor am I an OWNER), but the changes ...
5 years, 1 month ago (2015-10-29 08:42:53 UTC) #3
perkj_webrtc
On 2015/10/29 08:42:53, kwiberg-webrtc wrote: > lgtm > > I'm not familiar with this code ...
5 years, 1 month ago (2015-10-29 11:26:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425533003/1
5 years, 1 month ago (2015-10-29 11:48:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 11:50:13 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 11:50:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a35ae7f507cc4e909dd4253106c97528db315adb
Cr-Commit-Position: refs/heads/master@{#10447}

Powered by Google App Engine
This is Rietveld 408576698