Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1425233003: Hide ACMCodecDB::database_ behind accessors (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@rac-static
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Hide ACMCodecDB::database_ behind accessors BUG=webrtc:5028 Committed: https://crrev.com/4b938e5c6965316ad3366abc81572d081c6e443f Cr-Commit-Position: refs/heads/master@{#10498}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc View 2 chunks +1 line, -7 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kwiberg-webrtc
PTAL
5 years, 1 month ago (2015-11-02 07:10:47 UTC) #3
hlundin-webrtc
lgtm
5 years, 1 month ago (2015-11-03 08:32:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425233003/20001
5 years, 1 month ago (2015-11-03 19:48:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 20:38:31 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 20:38:39 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4b938e5c6965316ad3366abc81572d081c6e443f
Cr-Commit-Position: refs/heads/master@{#10498}

Powered by Google App Engine
This is Rietveld 408576698