Make VCMEncodedFrameCallback const.

Make VCMEncodedFrameCallback const.

Skips nullptr check.

BUG=
R=stefan@webrtc.org

Committed: https://crrev.com/4f5db11e45d8a371704d21e69a1849381d24321b
Cr-Commit-Position: refs/heads/master@{#10454}

[pbos-webrtc, 2015-10-27 13:05:00]

PTAL

[pbos-webrtc, 2015-10-27 13:05:05]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 13:05:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424843002/1

[commit-bot: I haz the power, 2015-10-27 14:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 14:06:10]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2015-10-29 07:28:06]

https://codereview.webrtc.org/1424843002/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.cc (right):

https://codereview.webrtc.org/1424843002/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.cc:114: }
Do we have to set these in Release(), given that we also set them in
InitEncode()?

https://codereview.webrtc.org/1424843002/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.cc:150:
vcm_encoded_frame_callback_->SetRotation(rotation_);
I don't like this... I think we should use a map from timestamp to rotation
instead, as we do on the decode side. Can you add a TODO?

[pbos-webrtc, 2015-10-29 15:50:53]

feedback

[pbos-webrtc, 2015-10-29 15:51:10]

PTAL, incl rebase though

https://codereview.webrtc.org/1424843002/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/main/source/generic_encoder.cc (right):

https://codereview.webrtc.org/1424843002/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.cc:114: }
On 2015/10/29 07:28:06, stefan-webrtc (holmer) wrote:
> Do we have to set these in Release(), given that we also set them in
> InitEncode()?

Executive decision says no.

https://codereview.webrtc.org/1424843002/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/main/source/generic_encoder.cc:150:
vcm_encoded_frame_callback_->SetRotation(rotation_);
On 2015/10/29 07:28:06, stefan-webrtc (holmer) wrote:
> I don't like this... I think we should use a map from timestamp to rotation
> instead, as we do on the decode side. Can you add a TODO?

Agreed, eew. Done.

[stefan-webrtc, 2015-10-29 15:53:16]

lgtm

[pbos-webrtc, 2015-10-29 15:54:14]

Committed patchset #2 (id:20001) manually as
4f5db11e45d8a371704d21e69a1849381d24321b (presubmit successful).

[commit-bot: I haz the power, 2015-10-29 15:54:17]

Patchset 2 (id:??) landed as
https://crrev.com/4f5db11e45d8a371704d21e69a1849381d24321b
Cr-Commit-Position: refs/heads/master@{#10454}