Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 1424803004: Revert of Adding the ability to change ICE servers through SetConfiguration. (Closed)

Created:
5 years, 1 month ago by Taylor Brandstetter
Modified:
5 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding the ability to change ICE servers through SetConfiguration. (patchset #7 id:120001 of https://codereview.webrtc.org/1391013007/ ) Reason for revert: Caused compiler warning, breaking Chrome FYI bots. Original issue's description: > Adding the ability to change ICE servers through SetConfiguration. > > Added a SetIceServers method to PortAllocator. Also added a new > PeerConnection Initialize method that takes a PortAllocator, in the > hope that we can get rid of PortAllocatorFactoryInterface, since the > only substantial thing a factory does is convert the webrtc:: ICE > servers to cricket:: versions. > > Committed: https://crrev.com/d3b26d94399ff539db375a9b84010ee75479d4cf > Cr-Commit-Position: refs/heads/master@{#10420} TBR=pthatcher@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/18a944bf0ac9eed872dc009bd58e6bc12c946303 Cr-Commit-Position: refs/heads/master@{#10421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -213 lines) Patch
M talk/app/webrtc/fakeportallocatorfactory.h View 3 chunks +1 line, -10 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 chunk +0 lines, -10 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 3 chunks +33 lines, -71 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M talk/app/webrtc/portallocatorfactory.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 3 chunks +0 lines, -27 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 6 chunks +29 lines, -14 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M webrtc/p2p/client/fakeportallocator.h View 2 chunks +1 line, -16 lines 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 4 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Taylor Brandstetter
Created Revert of Adding the ability to change ICE servers through SetConfiguration.
5 years, 1 month ago (2015-10-27 02:21:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424803004/1
5 years, 1 month ago (2015-10-27 02:21:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 02:21:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/18a944bf0ac9eed872dc009bd58e6bc12c946303 Cr-Commit-Position: refs/heads/master@{#10421}
5 years, 1 month ago (2015-10-27 02:21:55 UTC) #4
Taylor Brandstetter
5 years, 1 month ago (2015-10-27 02:38:46 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1414313003/ by deadbeef@webrtc.org.

The reason for reverting is: Relanding with compile warning fixed..

Powered by Google App Engine
This is Rietveld 408576698