Send back ping response if the ping comes from an unknown address.

Send back ping response if the ping comes from an unknown address.
BUG=webrtc:5171
Committed: https://crrev.com/9b5ee9c0d988b1d0dc64920937448e301dd45bd9
Cr-Commit-Position: refs/heads/master@{#10610}

[honghaiz3, 2015-11-05 21:52:21]

Description was changed from

==========
Send back ping response if the ping comes from an unknown address.
BUG=
==========

to

==========
Send back ping response if the ping comes from an unknown address.
BUG=webrtc:5171
==========

[honghaiz3, 2015-11-05 23:46:45]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2015-11-05 23:47:11]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2015-11-05 23:50:15]

honghaiz@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-11-11 01:19:12]

lgtm, with a nit

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:607:
connection->HandleBindingRequest(stun_msg);
I like this cleanup.

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/port.cc
File webrtc/p2p/base/port.cc (right):

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/port.cc#n...
webrtc/p2p/base/port.cc:965: const std::string& remote_ufrag =
remote_candidate_.username();
Nit: to be consistent, the first line should be:

const rtc::SocketAddress remote_addr = remote_candidate_.address();

[honghaiz3, 2015-11-11 19:27:54]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2015-11-11 19:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1424703012/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-11-11 19:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703012/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703012/80001

[honghaiz3, 2015-11-11 19:28:09]

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:607:
connection->HandleBindingRequest(stun_msg);
On 2015/11/11 01:19:12, pthatcher1 wrote:
> I like this cleanup.

Acknowledged.

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/port.cc
File webrtc/p2p/base/port.cc (right):

https://codereview.webrtc.org/1424703012/diff/60001/webrtc/p2p/base/port.cc#n...
webrtc/p2p/base/port.cc:965: const std::string& remote_ufrag =
remote_candidate_.username();
On 2015/11/11 01:19:12, pthatcher1 wrote:
> Nit: to be consistent, the first line should be:
> 
> const rtc::SocketAddress remote_addr = remote_candidate_.address();

Done. I kept the reference to avoid a copy.

[commit-bot: I haz the power, 2015-11-11 21:19:20]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-11-11 21:19:34]

Patchset 3 (id:??) landed as
https://crrev.com/9b5ee9c0d988b1d0dc64920937448e301dd45bd9
Cr-Commit-Position: refs/heads/master@{#10610}