webrtc/modules/audio_processing/voice_detection_impl.h - Issue 1424663003: Lock scheme #8: Introduced the new locking scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/voice_detection_impl.h

Issue 1424663003: Lock scheme #8: Introduced the new locking scheme (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@add_threadcheckers_CL

Patch Set: Major general updates, completing the locking scheme, and increasing readability Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_processing/noise_suppression_impl.h ('K') | « webrtc/modules/audio_processing/noise_suppression_impl.cc ('k') | webrtc/modules/audio_processing/voice_detection_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/voice_detection_impl.h

diff --git a/webrtc/modules/audio_processing/voice_detection_impl.h b/webrtc/modules/audio_processing/voice_detection_impl.h

index aebe422533f4f2830c1cbbc5230a7de49f8cd1af..05ae2305a61927e5602cbcdcb1206d458ff4ee20 100644

--- a/webrtc/modules/audio_processing/voice_detection_impl.h

+++ b/webrtc/modules/audio_processing/voice_detection_impl.h

@@ -11,6 +11,7 @@

#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_

#define WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_

+#include "webrtc/base/criticalsection.h"

#include "webrtc/base/thread_checker.h"

#include "webrtc/modules/audio_processing/include/audio_processing.h"

#include "webrtc/modules/audio_processing/processing_component.h"

@@ -23,7 +24,7 @@ class CriticalSectionWrapper;

class VoiceDetectionImpl : public VoiceDetection,

public ProcessingComponent {

public:

- VoiceDetectionImpl(const AudioProcessing* apm, CriticalSectionWrapper* crit);

+ VoiceDetectionImpl(const AudioProcessing* apm, rtc::CriticalSection* crit);

virtual ~VoiceDetectionImpl();

int ProcessCaptureAudio(AudioBuffer* audio);

@@ -53,7 +54,7 @@ class VoiceDetectionImpl : public VoiceDetection,

int GetHandleError(void* handle) const override;

const AudioProcessing* apm_;

- CriticalSectionWrapper* crit_;

+ rtc::CriticalSection* const crit_;

bool stream_has_voice_;

bool using_external_vad_;

Likelihood likelihood_;