Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1423493005: Revert of Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile. (Closed)

Created:
5 years, 1 month ago by åsapersson
Modified:
5 years, 1 month ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile. (patchset #3 id:40001 of https://codereview.webrtc.org/1427253002/ ) Reason for revert: Breaks bot. Original issue's description: > Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile. Max p_diff is 8 bits. > > Change type of number of reference pictures (size_t -> uint8_t). Max is 2 bits. > > Size of WebRtcRTPHeader: 4352 -> 1784 bytes. > > BUG=webrtc:5144, chromium:500602 > > Committed: https://crrev.com/81c5c7f8157f767747bd97419eb0a589207354cf > Cr-Commit-Position: refs/heads/master@{#10504} TBR=stefan@webrtc.org,mflodman@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5144, chromium:500602 Committed: https://crrev.com/5d4e944391043dddc36fc3d5570a34be1b286a5a Cr-Commit-Position: refs/heads/master@{#10508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M webrtc/modules/interface/module_common_types.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/main/source/jitter_buffer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/session_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
åsapersson
Created Revert of Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP ...
5 years, 1 month ago (2015-11-04 15:40:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423493005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423493005/1
5 years, 1 month ago (2015-11-04 15:40:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 15:40:39 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 15:40:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d4e944391043dddc36fc3d5570a34be1b286a5a
Cr-Commit-Position: refs/heads/master@{#10508}

Powered by Google App Engine
This is Rietveld 408576698