Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1423073006: VideoCapturerAndroid: Changed camera freeze check to check that all frames are pending before repor… (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Changed camera freeze check to check that all frames are pending before reporting a client error. BUG=b/25514149 Committed: https://crrev.com/83dfad685322119ffe85ff5670cabbbaf385a111 Cr-Commit-Position: refs/heads/master@{#10563}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 6 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
perkj_webrtc
please?
5 years, 1 month ago (2015-11-09 12:43:30 UTC) #2
magjed_webrtc
https://codereview.webrtc.org/1423073006/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1423073006/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java#newcode141 talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:141: if (CAMERA_OBSERVER_PERIOD_MS * freezePeriodCount > CAMERA_FREEZE_REPORT_TIMOUT_MS && && should ...
5 years, 1 month ago (2015-11-09 12:54:46 UTC) #3
perkj_webrtc
PTAL https://codereview.webrtc.org/1423073006/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1423073006/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java#newcode141 talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:141: if (CAMERA_OBSERVER_PERIOD_MS * freezePeriodCount > CAMERA_FREEZE_REPORT_TIMOUT_MS && On ...
5 years, 1 month ago (2015-11-09 13:46:58 UTC) #4
magjed_webrtc
lgtm
5 years, 1 month ago (2015-11-09 14:12:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423073006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423073006/20001
5 years, 1 month ago (2015-11-09 14:15:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-09 15:39:52 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 15:40:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83dfad685322119ffe85ff5670cabbbaf385a111
Cr-Commit-Position: refs/heads/master@{#10563}

Powered by Google App Engine
This is Rietveld 408576698