webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc - Issue 1423043005: Remove ACMCodecDB::Codec, and make the rest of ACMCodecDB private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc

Issue 1423043005: Remove ACMCodecDB::Codec, and make the rest of ACMCodecDB private (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@rac3

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc ('k') | webrtc/modules/audio_coding/main/acm2/codec_manager.cc » ('j') | webrtc/modules/audio_coding/main/acm2/codec_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc b/webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc

index 64344833407e6fadd610202c337a3f807a257a6e..dae24a3320ee7f2210724b779e57cbff3d78653b 100644

--- a/webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc

+++ b/webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc

@@ -88,8 +88,8 @@ class AcmReceiverTestOldApi : public AudioPacketizationCallback,

void TearDown() override {}

void InsertOnePacketOfSilence(int codec_id) {

- CodecInst codec;

- ACMCodecDB::Codec(codec_id, &codec);

+ CodecInst codec =

+ *RentACodec::CodecInstById(*RentACodec::CodecIdFromIndex(codec_id));

hlundin-webrtc 2015/11/05 11:57:49 What happens if you try to dereference an empty rt

kwiberg-webrtc 2015/11/05 12:27:52 DCHECK Since the old code ignored the possibility

hlundin-webrtc 2015/11/05 12:30:37 Fair enough.

if (timestamp_ == 0) { // This is the first time inserting audio.

ASSERT_EQ(0, acm_->RegisterSendCodec(codec));

} else {