Android MediaCodecVideoDecoder: Manage lifetime of texture frames

webrtc/modules/video_coding/main/source/generic_decoder.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 28 matching lines @@
     CriticalSectionScoped cs(_critSect);
     _receiveCallback = receiveCallback;
 }
 
 VCMReceiveCallback* VCMDecodedFrameCallback::UserReceiveCallback()
 {
     CriticalSectionScoped cs(_critSect);
     return _receiveCallback;
 }
 
+int32_t VCMDecodedFrameCallback::Decoded(VideoFrame& decodedImage,
+    int decodeTimeInMs) {
+  // TODO(holmer): We should improve this so that we can handle multiple
+   // callbacks from one call to Decode().
+   VCMFrameInformation* frameInfo;
+   VCMReceiveCallback* callback;
+   {
+       CriticalSectionScoped cs(_critSect);
+       frameInfo = _timestampMap.Pop(decodedImage.timestamp());
+       callback = _receiveCallback;
+   }
+
+   if (frameInfo == NULL) {
+     LOG(LS_WARNING) << "Too many frames backed up in the decoder, dropping "
+                        "this one.";
+     return WEBRTC_VIDEO_CODEC_OK;
+   }
+
+   int64_t stopTime =
+       (decodeTimeInMs != 0) ?  frameInfo->decodeStartTimeMs + decodeTimeInMs :

[magjed_webrtc, 2015/10/28 11:57:16]

I think you should make this lessy hacky and land separately.

+           _clock->TimeInMilliseconds();
+   _timing.StopDecodeTimer(
+       decodedImage.timestamp(),
+       frameInfo->decodeStartTimeMs,
+       stopTime,
+       frameInfo->renderTimeMs);
+
+   if (callback != NULL)
+   {
+       decodedImage.set_render_time_ms(frameInfo->renderTimeMs);
+       decodedImage.set_rotation(frameInfo->rotation);
+       callback->FrameToRender(decodedImage);
+   }
+   return WEBRTC_VIDEO_CODEC_OK;
+}
+
 int32_t VCMDecodedFrameCallback::Decoded(VideoFrame& decodedImage) {
-    // TODO(holmer): We should improve this so that we can handle multiple
-    // callbacks from one call to Decode().
-    VCMFrameInformation* frameInfo;
-    VCMReceiveCallback* callback;
-    {
-        CriticalSectionScoped cs(_critSect);
-        frameInfo = _timestampMap.Pop(decodedImage.timestamp());
-        callback = _receiveCallback;
-    }
-
-    if (frameInfo == NULL) {
-      LOG(LS_WARNING) << "Too many frames backed up in the decoder, dropping "
-                         "this one.";
-      return WEBRTC_VIDEO_CODEC_OK;
-    }
-
-    _timing.StopDecodeTimer(
-        decodedImage.timestamp(),
-        frameInfo->decodeStartTimeMs,
-        _clock->TimeInMilliseconds(),
-        frameInfo->renderTimeMs);
-
-    if (callback != NULL)
-    {
-        decodedImage.set_render_time_ms(frameInfo->renderTimeMs);
-        decodedImage.set_rotation(frameInfo->rotation);
-        callback->FrameToRender(decodedImage);
-    }
-    return WEBRTC_VIDEO_CODEC_OK;
+  return Decoded(decodedImage, 0);
 }
 
 int32_t
 VCMDecodedFrameCallback::ReceivedDecodedReferenceFrame(
     const uint64_t pictureId)
 {
     CriticalSectionScoped cs(_critSect);
     if (_receiveCallback != NULL)
     {
         return _receiveCallback->ReceivedDecodedReferenceFrame(pictureId);
@@ skipping 100 matching lines @@
     _callback = callback;
     return _decoder.RegisterDecodeCompleteCallback(callback);
 }
 
 bool VCMGenericDecoder::External() const
 {
     return _isExternal;
 }
 
 }  // namespace