Separate StunProber::Start into Prepare and Run so we could create multiple of them and send out ST…

Separate StunProber::Start into Prepare and Run so we could create multiple of them and send out STUN pings at regular interval.

Also update the wake up logic to handle the case if <5 ms interval is requested.

BUG=

Committed: https://crrev.com/00507f8eb6d1dd897315044f4753d145af9ebf55
Cr-Commit-Position: refs/heads/master@{#10381}

[guoweis_webrtc, 2015-10-21 17:35:22]

Description was changed from

==========
Separate StunProber::Start into Prepare and Run so we could create multiple of
them and send out STUN pings at regular interval.

BUG=
==========

to

==========
Separate StunProber::Start into Prepare and Run so we could create multiple of
them and send out STUN pings at regular interval.

Also update the wake up logic to handle the case if <5 ms interval is requested.

BUG=
==========

[guoweis_webrtc, 2015-10-21 17:35:35]

guoweis@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[guoweis_webrtc, 2015-10-21 17:35:35]

PTAL.

[pthatcher1, 2015-10-22 22:26:22]

lgtm, with nits

https://codereview.webrtc.org/1422593002/diff/120001/webrtc/p2p/stunprober/st...
File webrtc/p2p/stunprober/stunprober.h (right):

https://codereview.webrtc.org/1422593002/diff/120001/webrtc/p2p/stunprober/st...
webrtc/p2p/stunprober/stunprober.h:128: bool Run(StunProber::Observer*
observer);
Run makes it sound synchronous.  

Shouldn't we call this Start() also?

https://codereview.webrtc.org/1422593002/diff/120001/webrtc/p2p/stunprober/st...
webrtc/p2p/stunprober/stunprober.h:136: // |all_servers_addrs_|.size() *
|interval_ms_|.
This comment is just a duplication of the method name and code.  You could
probably remove it.

[guoweis_webrtc, 2015-10-23 00:54:15]

The CQ bit was checked by guoweis@webrtc.org

[guoweis_webrtc, 2015-10-23 00:54:16]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1422593002/#ps140001 (title:
" ")

[commit-bot: I haz the power, 2015-10-23 00:54:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422593002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422593002/140001

[commit-bot: I haz the power, 2015-10-23 01:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 01:01:04]

Try jobs failed on following builders:
  win_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/10150)

[guoweis_webrtc, 2015-10-23 01:26:48]

The CQ bit was checked by guoweis@webrtc.org

[guoweis_webrtc, 2015-10-23 01:26:48]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1422593002/#ps160001 (title:
" ")

[commit-bot: I haz the power, 2015-10-23 01:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422593002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422593002/160001

[commit-bot: I haz the power, 2015-10-23 02:16:00]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-10-23 02:16:13]

Patchset 9 (id:??) landed as
https://crrev.com/00507f8eb6d1dd897315044f4753d145af9ebf55
Cr-Commit-Position: refs/heads/master@{#10381}