Attempt to open Android camera later if it is already in use.

Attempt to open Android camera later if it is already in use.

This change VideoCapturerAndroid to attempt 3 times with a period of 300ms to open the camera if it fails.
This is so that if another application have it already opened, it would have more time to release it.
BUG=b/25190234

Committed: https://crrev.com/89ef6cc13e8aa9f16b212dd82124f4297a1f7385
Cr-Commit-Position: refs/heads/master@{#10559}

[perkj_webrtc, 2015-11-05 20:18:18]

Description was changed from

==========
Attempt to open Android camera later if it is already in use.

This change VideoCapturerAndroid to attempt 3 times with a period of 300ms to
open the camera if it fails.
This is so that if another application have it already opened, it would have
more time to release it.
BUG=
==========

to

==========
Attempt to open Android camera later if it is already in use.

This change VideoCapturerAndroid to attempt 3 times with a period of 300ms to
open the camera if it fails.
This is so that if another application have it already opened, it would have
more time to release it.
BUG=b/25190234
==========

[perkj_webrtc, 2015-11-05 20:18:18]

perkj@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[perkj_webrtc, 2015-11-05 20:19:04]

Can you please review?

[AlexG, 2015-11-06 18:07:17]

lgtm

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:464:
cameraThreadHandler.postDelayed(openCameraOnCodecThreadRunner,
OPEN_CAMERA_DELAY_MS);
nit: may be loop will be a little clearer than recursion? Or you want to avoid
blocking camera thread between camera open attempts?

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:466: }
nit: May be set openCameraAttempts = 0 here - if stopCamera will not be called
this camera failure should not affect app if it decided to try to open camera
one more time later

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:487: 
nit: extra line?

[perkj_webrtc, 2015-11-09 07:38:59]

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:464:
cameraThreadHandler.postDelayed(openCameraOnCodecThreadRunner,
OPEN_CAMERA_DELAY_MS);
On 2015/11/06 18:07:17, AlexG wrote:
> nit: may be loop will be a little clearer than recursion? Or you want to avoid
> blocking camera thread between camera open attempts?

And I want to avoid blocking a Stop call. If I loop, VideoCapturerer.Stop would
wait for 6s.

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:466: }
On 2015/11/06 18:07:17, AlexG wrote:
> nit: May be set openCameraAttempts = 0 here - if stopCamera will not be called
> this camera failure should not affect app if it decided to try to open camera
> one more time later

Done.

https://codereview.webrtc.org/1422023007/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:487: 
On 2015/11/06 18:07:17, AlexG wrote:
> nit: extra line?

Done.

[perkj_webrtc, 2015-11-09 07:39:04]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2015-11-09 07:39:05]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1422023007/#ps20001 (title:
"Addressed comments.")

[commit-bot: I haz the power, 2015-11-09 07:39:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422023007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422023007/20001

[commit-bot: I haz the power, 2015-11-09 07:40:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 07:40:09]

Try jobs failed on following builders:
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/10609)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/9234)
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/993)
  mac_x64_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_dbg/builds/5120)

[perkj_webrtc, 2015-11-09 08:45:15]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2015-11-09 08:45:15]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1422023007/#ps60001 (title:
"Removed unused code.")

[commit-bot: I haz the power, 2015-11-09 08:45:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422023007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422023007/60001

[commit-bot: I haz the power, 2015-11-09 09:35:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-09 09:35:35]

Patchset 4 (id:??) landed as
https://crrev.com/89ef6cc13e8aa9f16b212dd82124f4297a1f7385
Cr-Commit-Position: refs/heads/master@{#10559}