Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1422023002: Use webrtc/base/logging.h for rtp_rtcp. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use webrtc/base/logging.h for rtp_rtcp. BUG=webrtc:5118 R=stefan@webrtc.org Committed: https://crrev.com/ebc0b4e99365443111857a0c7cfcc8944d8f1b6e Cr-Commit-Position: refs/heads/master@{#10437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M webrtc/modules/rtp_rtcp/source/fec_receiver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/h264_sps_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/remote_ntp_time_estimator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp8.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422023002/1
5 years, 1 month ago (2015-10-26 10:18:04 UTC) #2
pbos-webrtc
PTAL, this makes it log straight without bouncing in webrtcvoiceengine.cc (shorter log lines), the goal ...
5 years, 1 month ago (2015-10-26 10:22:58 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 11:07:45 UTC) #5
stefan-webrtc
lgtm
5 years, 1 month ago (2015-10-28 15:32:44 UTC) #6
pbos-webrtc
Committed patchset #1 (id:1) manually as ebc0b4e99365443111857a0c7cfcc8944d8f1b6e (presubmit successful).
5 years, 1 month ago (2015-10-28 15:39:49 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 15:39:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebc0b4e99365443111857a0c7cfcc8944d8f1b6e
Cr-Commit-Position: refs/heads/master@{#10437}

Powered by Google App Engine
This is Rietveld 408576698