Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421463008: Remove old system_wrappers event_tracer.h. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Andrew MacDonald, peah-webrtc, mflodman, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove old system_wrappers event_tracer.h. Replaced by webrtc/base/event_tracer.h and no longer used. BUG= R=tommi@webrtc.org Committed: https://crrev.com/dc0da59ebaafb575a0a1d7740e8440435683eaad Cr-Commit-Position: refs/heads/master@{#10537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M webrtc/system_wrappers/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/system_wrappers/include/event_tracer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D webrtc/system_wrappers/source/event_tracer.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D webrtc/system_wrappers/source/event_tracer_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
pbos-webrtc
PTAL, woo.
5 years, 1 month ago (2015-11-05 19:06:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421463008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421463008/1
5 years, 1 month ago (2015-11-05 19:06:55 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-05 21:07:13 UTC) #5
tommi
lgtm
5 years, 1 month ago (2015-11-06 00:21:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421463008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421463008/1
5 years, 1 month ago (2015-11-06 00:21:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-06 02:21:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421463008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421463008/1
5 years, 1 month ago (2015-11-06 10:13:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 10:16:51 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 10:17:01 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc0da59ebaafb575a0a1d7740e8440435683eaad
Cr-Commit-Position: refs/heads/master@{#10537}

Powered by Google App Engine
This is Rietveld 408576698