Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1421013006: Delete a chain of methods in ViE, VoE and ACM (Closed)

Created:
5 years, 1 month ago by hlundin-webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, mflodman, peah-webrtc, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete a chain of methods in ViE, VoE and ACM The end goal is to remove AcmReceiver::SetInitialDelay. This change is in preparation for that goal. It turns out that AcmReceiver::SetInitialDelay was only invoked through the following call chain, where each method in the chain is never referenced from anywhere else (except from tests in some cases): ViEChannel::SetReceiverBufferingMode -> ViESyncModule::SetTargetBufferingDelay -> VoEVideoSync::SetInitialPlayoutDelay -> Channel::SetInitialPlayoutDelay -> AudioCodingModule::SetInitialPlayoutDelay -> AcmReceiver::SetInitialDelay The start of the chain, ViEChannel::SetReceiverBufferingMode was never referenced. This change deletes all the methods above except AcmReceiver::SetInitialDelay itself, which will be handled in a follow-up change. BUG=webrtc:3520 Committed: https://crrev.com/74f0f3551ecd596dc0f83146d218887082528fa8 Cr-Commit-Position: refs/heads/master@{#10471}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -341 lines) Patch
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/modules/audio_coding/main/include/audio_coding_module.h View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/delay_test.cc View 3 chunks +1 line, -6 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc View 1 chunk +0 lines, -175 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/insert_packet_with_timing.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/fake_voice_engine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M webrtc/video_engine/vie_sync_module.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video_engine/vie_sync_module.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M webrtc/voice_engine/include/voe_video_sync.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/voice_engine/voe_video_sync_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voe_video_sync_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hlundin-webrtc
Please, review this CL. kwiberg: webrtc/modules/ pbos: webrtc/test/, webrtc/video_engine/ henrika: webrtc/voice_engine/ Thanks!
5 years, 1 month ago (2015-10-30 06:46:24 UTC) #5
henrika_webrtc
henrika: webrtc/voice_engine/ => LGTM
5 years, 1 month ago (2015-10-30 08:15:05 UTC) #6
pbos-webrtc
webrtc/{test,video_engine}: LGTM
5 years, 1 month ago (2015-10-30 09:33:33 UTC) #7
kwiberg-webrtc
webrtc/modules/: lgtm
5 years, 1 month ago (2015-11-01 10:56:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421013006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421013006/40001
5 years, 1 month ago (2015-11-01 18:51:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-11-01 19:43:35 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-01 19:43:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74f0f3551ecd596dc0f83146d218887082528fa8
Cr-Commit-Position: refs/heads/master@{#10471}

Powered by Google App Engine
This is Rietveld 408576698