Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2234)

Unified Diff: dl/sp/api/armSP.h

Issue 1420973006: arm64: clang assembler compatability (Closed) Base URL: https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dl/sp/src/arm/arm64/ComplexToRealFixup.S » ('j') | dl/sp/src/arm/arm64/ComplexToRealFixup.S » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dl/sp/api/armSP.h
diff --git a/dl/sp/api/armSP.h b/dl/sp/api/armSP.h
index 2592679c759c2149120f83ec2668c04ede212a2b..54ae05bf14393e525c5fc42f66ebafbc6bf94ee9 100644
--- a/dl/sp/api/armSP.h
+++ b/dl/sp/api/armSP.h
@@ -93,11 +93,11 @@ typedef struct ARMsFFTSpec_FC32_Tag
/*
* Compute log2(x), where x must be a power of 2.
*/
-static inline OMX_U32 fastlog2(long x) {
+static inline OMX_U32 fastlog2(OMX_U32 x) {
Raymond Toy (Google) 2015/10/30 22:38:46 Why the change from long to OMX_U32?
Riku Voipio 2015/11/02 12:24:12 clang throws a warning: ../../third_party/openmax_
OMX_U32 out;
- asm("clz %0,%1\n\t"
- "sub %0, %0, #63\n\t"
- "neg %0, %0\n\t"
+ asm("clz %w0,%w1\n\t"
+ "sub %w0, %w0, #63\n\t"
Raymond Toy (Google) 2015/10/30 22:38:46 If %w0 means a 32-bit register than clz is probabl
Riku Voipio 2015/11/02 12:24:12 Will be fixed in the next iteration by keeping the
+ "neg %w0, %w0\n\t"
: "=r"(out)
: "r"(x)
:);
« no previous file with comments | « no previous file | dl/sp/src/arm/arm64/ComplexToRealFixup.S » ('j') | dl/sp/src/arm/arm64/ComplexToRealFixup.S » ('J')

Powered by Google App Engine
This is Rietveld 408576698