Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420653006: Cleanup workaround for grit version dependency (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup workaround for grit version dependency BUG=webrtc:5160 R=phoglund@webrtc.org Committed: https://crrev.com/698aa8d26e9916b8eb716a589354bd51b7e3f06d Cr-Commit-Position: refs/heads/master@{#10540}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
M setup_links.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
This depended on https://codereview.chromium.org/1419503006/ being landed and rolled into WebRTC. which has happened in https://codereview.webrtc.org/1405063007/
5 years, 1 month ago (2015-11-05 20:27:26 UTC) #3
phoglund
lgtm
5 years, 1 month ago (2015-11-06 07:58:55 UTC) #4
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 698aa8d26e9916b8eb716a589354bd51b7e3f06d (presubmit successful).
5 years, 1 month ago (2015-11-06 12:45:40 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 12:45:44 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/698aa8d26e9916b8eb716a589354bd51b7e3f06d
Cr-Commit-Position: refs/heads/master@{#10540}

Powered by Google App Engine
This is Rietveld 408576698