webrtc/base/criticalsection.h - Issue 1420043008: Create rtc::AtomicInt POD struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/criticalsection.h

Issue 1420043008: Create rtc::AtomicInt POD struct. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: ctor version, let's pray they are put in .data or .bss Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/criticalsection.h

diff --git a/webrtc/base/criticalsection.h b/webrtc/base/criticalsection.h

index ddbf857f2b15cc49bca4c13e72a011fcc4b7d87b..5e8bfdb35a27ad40e7464e6c5c06742a1210e2bf 100644

--- a/webrtc/base/criticalsection.h

+++ b/webrtc/base/criticalsection.h

@@ -102,11 +102,12 @@ class TryCritScope {

// No custom constructor or private data member should be added.

class LOCKABLE GlobalLockPod {

public:

+ GlobalLockPod() : lock_acquired(0) {}

void Lock() EXCLUSIVE_LOCK_FUNCTION();

void Unlock() UNLOCK_FUNCTION();

- volatile int lock_acquired;

+ AtomicInt lock_acquired;

};

class GlobalLock : public GlobalLockPod {