Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: webrtc/base/atomicops.h

Issue 1420043008: Create rtc::AtomicInt POD struct. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: ctor version, let's pray they are put in .data or .bss Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/base/criticalsection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2011 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_BASE_ATOMICOPS_H_ 11 #ifndef WEBRTC_BASE_ATOMICOPS_H_
12 #define WEBRTC_BASE_ATOMICOPS_H_ 12 #define WEBRTC_BASE_ATOMICOPS_H_
13 13
14 #if defined(WEBRTC_WIN) 14 #if defined(WEBRTC_WIN)
15 // Include winsock2.h before including <windows.h> to maintain consistency with 15 // Include winsock2.h before including <windows.h> to maintain consistency with
16 // win32.h. We can't include win32.h directly here since it pulls in 16 // win32.h. We can't include win32.h directly here since it pulls in
17 // headers such as basictypes.h which causes problems in Chromium where webrtc 17 // headers such as basictypes.h which causes problems in Chromium where webrtc
18 // exists as two separate projects, webrtc and libjingle. 18 // exists as two separate projects, webrtc and libjingle.
19 #include <winsock2.h> 19 #include <winsock2.h>
20 #include <windows.h> 20 #include <windows.h>
21 #endif // defined(WEBRTC_WIN) 21 #endif // defined(WEBRTC_WIN)
22 22
23 #include "webrtc/base/constructormagic.h"
24
23 namespace rtc { 25 namespace rtc {
26
24 class AtomicOps { 27 class AtomicOps {
25 public: 28 public:
26 #if defined(WEBRTC_WIN) 29 #if defined(WEBRTC_WIN)
27 // Assumes sizeof(int) == sizeof(LONG), which it is on Win32 and Win64. 30 // Assumes sizeof(int) == sizeof(LONG), which it is on Win32 and Win64.
28 static int Increment(volatile int* i) { 31 static int Increment(volatile int* i) {
29 return ::InterlockedIncrement(reinterpret_cast<volatile LONG*>(i)); 32 return ::InterlockedIncrement(reinterpret_cast<volatile LONG*>(i));
30 } 33 }
31 static int Decrement(volatile int* i) { 34 static int Decrement(volatile int* i) {
32 return ::InterlockedDecrement(reinterpret_cast<volatile LONG*>(i)); 35 return ::InterlockedDecrement(reinterpret_cast<volatile LONG*>(i));
33 } 36 }
(...skipping 20 matching lines...) Expand all
54 } 57 }
55 static void ReleaseStore(volatile int* i, int value) { 58 static void ReleaseStore(volatile int* i, int value) {
56 __atomic_store_n(i, value, __ATOMIC_RELEASE); 59 __atomic_store_n(i, value, __ATOMIC_RELEASE);
57 } 60 }
58 static int CompareAndSwap(volatile int* i, int old_value, int new_value) { 61 static int CompareAndSwap(volatile int* i, int old_value, int new_value) {
59 return __sync_val_compare_and_swap(i, old_value, new_value); 62 return __sync_val_compare_and_swap(i, old_value, new_value);
60 } 63 }
61 #endif 64 #endif
62 }; 65 };
63 66
67 // POD struct version of AtomicOps, prevents accidental non-atomic operator
tommi 2015/11/11 15:58:37 nit: unintentional whitespace of doom
pbos-webrtc 2015/11/16 18:10:42 Done.
68 // usage (such as ++, -- or =). Functions are static, so that the AtomicInt::
69 // prefix must be present in the code, clearly labeling the operations as
70 // atomic.
71 struct AtomicInt {
72 explicit AtomicInt(int value) : value_(value) {}
64 73
74 // Atomically increments |i|, returns the resulting incremented value.
75 static int Increment(AtomicInt* i) {
76 return AtomicOps::Increment(&i->value_);
77 }
65 78
79 // Atomically decrements |i|, returns the resulting decremented value.
80 static int Decrement(AtomicInt* i) {
81 return AtomicOps::Decrement(&i->value_);
82 }
83
84 // Atomically loads |i|.
85 static int AcquireLoad(const AtomicInt* i) {
86 return AtomicOps::AcquireLoad(&i->value_);
87 }
88
89 // Atomically stores |value| in |i|.
90 static void ReleaseStore(AtomicInt* i, int value) {
91 AtomicOps::ReleaseStore(&i->value_, value);
92 }
93
94 // Attempts to compare-and-swaps |old_value| for |new_value| in |i| , returns
95 // |i|'s initial value. If equal to |old_value|, then the CAS succeeded,
96 // otherwise no operation is performed.
97 static int CompareAndSwap(AtomicInt* i, int old_value, int new_value) {
98 return AtomicOps::CompareAndSwap(&i->value_, old_value, new_value);
99 }
100
101 private:
102 volatile int value_;
103
104 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(AtomicInt);
105 };
66 } 106 }
67 107
68 #endif // WEBRTC_BASE_ATOMICOPS_H_ 108 #endif // WEBRTC_BASE_ATOMICOPS_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/criticalsection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698