Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1419953003: Fix for Mac GN BUILD. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix for Mac GN BUILD. It can't find //webrtc/base:rtc_base, which is weird, the fix is to use a relative path. This should fix the following error: ERROR at //third_party/webrtc/sound/BUILD.gn:38:5: Can't load input file. "//webrtc/base:rtc_base", ^----------------------- NOTRY=true BUG=webrtc:4160 TBR=kjellander@webrtc.org Committed: https://crrev.com/2d3747de9b7c3014e106d3766dc07cf5da3e1881 Cr-Commit-Position: refs/heads/master@{#10407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/sound/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419953003/1
5 years, 1 month ago (2015-10-26 12:23:46 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-10-26 12:23:48 UTC) #4
tfarina
Fix for http://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20GN/builds/7811/steps/generate_build_files/logs/stdio Looks like I can't TBR you though. PTAL!
5 years, 1 month ago (2015-10-26 12:24:47 UTC) #5
kjellander_webrtc
Ah, too bad we can't catch these with our current trybots yet (we need such ...
5 years, 1 month ago (2015-10-26 12:36:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419953003/1
5 years, 1 month ago (2015-10-26 12:36:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 12:47:41 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 12:47:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d3747de9b7c3014e106d3766dc07cf5da3e1881
Cr-Commit-Position: refs/heads/master@{#10407}

Powered by Google App Engine
This is Rietveld 408576698