webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java - Issue 1419693004: Fix for "Android audio playout doesn't support non-call media stream"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java

Issue 1419693004: Fix for "Android audio playout doesn't support non-call media stream" (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback from magjed@ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java ('k') | webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java

diff --git a/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java b/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java

index ff776358436699ef976b692a8cea71d98cfdbeea..7b31e08eed2a4817a652ad8eddb112e1c14379b0 100644

--- a/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java

+++ b/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java

@@ -192,6 +192,10 @@ class WebRtcAudioRecord {

Math.max(BUFFER_SIZE_FACTOR * minBufferSize, byteBuffer.capacity());

Logging.d(TAG, "bufferSizeInBytes: " + bufferSizeInBytes);

try {

+ // TODO(henrika): the only supported audio source for input is currently

+ // AudioSource.VOICE_COMMUNICATION. Is there any reason why we should

+ // support other types, e.g. DEFAULT or MIC? Only reason I can think of

+ // is if the device does not support VOICE_COMMUNICATION.

audioRecord = new AudioRecord(AudioSource.VOICE_COMMUNICATION,

sampleRate,

AudioFormat.CHANNEL_IN_MONO,