 Chromium Code Reviews
 Chromium Code Reviews Issue 1419673014:
  Remove frame time scheduing in IncomingVideoStream  (Closed) 
  Base URL: https://chromium.googlesource.com/external/webrtc.git@master
    
  
    Issue 1419673014:
  Remove frame time scheduing in IncomingVideoStream  (Closed) 
  Base URL: https://chromium.googlesource.com/external/webrtc.git@master| Index: webrtc/common_video/include/incoming_video_stream.h | 
| diff --git a/webrtc/common_video/include/incoming_video_stream.h b/webrtc/common_video/include/incoming_video_stream.h | 
| index cd0d65385e886b5453bc28c752d693b7c29e145e..c963da0931e0056db81a0cb56dd22db9b9072d15 100644 | 
| --- a/webrtc/common_video/include/incoming_video_stream.h | 
| +++ b/webrtc/common_video/include/incoming_video_stream.h | 
| @@ -19,6 +19,7 @@ namespace webrtc { | 
| class CriticalSectionWrapper; | 
| class EventTimerWrapper; | 
| class ThreadWrapper; | 
| +class VideoRenderer; | 
| class VideoRenderCallback { | 
| public: | 
| @@ -32,6 +33,7 @@ class VideoRenderCallback { | 
| class IncomingVideoStream : public VideoRenderCallback { | 
| public: | 
| explicit IncomingVideoStream(uint32_t stream_id); | 
| 
pbos-webrtc
2015/11/23 14:28:05
Can you just have a bool disable_prerender_smoothi
 
mflodman
2015/11/23 14:43:44
+1, I assume this won't change during the life tim
 
qiangchen
2015/11/24 00:21:05
Done.
But one concern is the compatibility break,
 
mflodman
2015/11/24 12:21:17
AFAIK this is only used by internal WebRTC code an
 | 
| + IncomingVideoStream(uint32_t stream_id, VideoRenderer* renderer); | 
| ~IncomingVideoStream(); | 
| // Get callback to deliver frames to the module. | 
| @@ -73,6 +75,7 @@ class IncomingVideoStream : public VideoRenderCallback { | 
| enum { kFrameRatePeriodMs = 1000 }; | 
| uint32_t const stream_id_; | 
| + VideoRenderer* const renderer_; | 
| // Critsects in allowed to enter order. | 
| const rtc::scoped_ptr<CriticalSectionWrapper> stream_critsect_; | 
| const rtc::scoped_ptr<CriticalSectionWrapper> thread_critsect_; |