Skip logging RTCP messages of type SDES and APP.

Removed cname and receiver_reference_time_report from proto and logging code. Changed logging of RTCP to omit messages of type SDES and APP.

BUG=

Committed: https://crrev.com/d66daa2d2f9fe8ea2bd0e912e2d8c6c4f388f14e
Cr-Commit-Position: refs/heads/master@{#10542}

[terelius, 2015-10-26 08:44:58]

Description was changed from

==========
Removed cname and receiver_reference_time_report from proto and logging code.
Changed logging of RTCP to omit messages of type SDES and APP.

BUG=
==========

to

==========
Removed cname and receiver_reference_time_report from proto and logging code.
Changed logging of RTCP to omit messages of type SDES and APP.

BUG=
==========

[terelius, 2015-10-26 08:44:58]

terelius@webrtc.org changed reviewers:
+ asapersson@webrtc.org, ivoc@webrtc.org, stefan@webrtc.org

[terelius, 2015-10-26 08:51:03]

Ivo & Stefan, please have a look at this CL which removes APP and SDES from the
RTCP messages and CNAME from the stream configuration.

Åsa, could you have a look at the use of RTCPSender and RTCPUtility in the
functions GenerateRtcpPacket and RtcEventLogImpl::LogRtpHeader?

[stefan-webrtc, 2015-10-28 13:37:12]

lgtm

https://codereview.webrtc.org/1419523004/diff/20001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/1419523004/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:390: // return packet_size;
Should this code be removed?

[åsapersson, 2015-10-28 14:16:43]

https://codereview.webrtc.org/1419523004/diff/20001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/1419523004/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:336: void GenerateRtcpPacket(rtc::Buffer*
packet) {
To generate rtcp packets, the RtcpPacket class could perhaps be used directly.

For example, could something like this be used?

  ReportBlock rb;
  rb.To(kRemoteSsrc);
  rb.WithFractionLost(55);

  SenderReport sr;
  sr.From(kSenderSsrc);
  sr.WithNtpSec(123);
  sr.WithNtpFrac(456);
  sr.WithReportBlock(rb);
  rtc::scoped_ptr<RawPacket> packet(sr.Build());

[terelius, 2015-10-30 11:17:19]

https://codereview.webrtc.org/1419523004/diff/20001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/1419523004/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:336: void GenerateRtcpPacket(rtc::Buffer*
packet) {
On 2015/10/28 14:16:43, åsapersson wrote:
> To generate rtcp packets, the RtcpPacket class could perhaps be used directly.
> 
> For example, could something like this be used?
> 
>   ReportBlock rb;
>   rb.To(kRemoteSsrc);
>   rb.WithFractionLost(55);
> 
>   SenderReport sr;
>   sr.From(kSenderSsrc);
>   sr.WithNtpSec(123);
>   sr.WithNtpFrac(456);
>   sr.WithReportBlock(rb);
>   rtc::scoped_ptr<RawPacket> packet(sr.Build());
> 

Thanks for the suggestion; the new code is much cleaner.

https://codereview.webrtc.org/1419523004/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:390: // return packet_size;
On 2015/10/28 13:37:12, stefan-webrtc (holmer) wrote:
> Should this code be removed?

Yes. Done.

[åsapersson, 2015-11-02 09:31:12]

lgtm

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log.cc:382: if (block_begin + block_size > packet_end) {
Is this checked within RtcpParseCommonHeader?

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:338: report_block.To(rand());  //
kRemoteSsrc
// remote SSRC

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:339:
report_block.WithFractionLost(rand()%50);
nit: add spaces before and after %

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:342: sender_report.From(rand());  //
kSenderSsrc
// sender SSRC

[ivoc, 2015-11-02 10:51:18]

Nice, LGTM. See one question below.

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:14: #include <string.h>
Is this used anywhere?

[terelius, 2015-11-05 18:01:19]

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log.cc:382: if (block_begin + block_size > packet_end) {
On 2015/11/02 09:31:12, åsapersson wrote:
> Is this checked within RtcpParseCommonHeader?

You're right. It has already been verified in RtcpParseCommonHeader. I've
removed this redundant check.

It seems similar redundant checks exists in RTCPParserV2::IterateTopLevel() and
RTCPPacketIterator::Iterate() though.

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:14: #include <string.h>
On 2015/11/02 10:51:18, ivoc wrote:
> Is this used anywhere? 

You're right. It was used to access memcpy in a previous version. I've removed
it.

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:338: report_block.To(rand());  //
kRemoteSsrc
On 2015/11/02 09:31:12, åsapersson wrote:
> // remote SSRC

Done.

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:339:
report_block.WithFractionLost(rand()%50);
On 2015/11/02 09:31:12, åsapersson wrote:
> nit: add spaces before and after %

Done.

https://codereview.webrtc.org/1419523004/diff/40001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_unittest.cc:342: sender_report.From(rand());  //
kSenderSsrc
On 2015/11/02 09:31:12, åsapersson wrote:
> // sender SSRC

Done.

[terelius, 2015-11-06 16:52:20]

The CQ bit was checked by terelius@webrtc.org

[terelius, 2015-11-06 16:52:21]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
ivoc@webrtc.org, asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1419523004/#ps80001 (title:
"Major rebase")

[commit-bot: I haz the power, 2015-11-06 16:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419523004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419523004/80001

[commit-bot: I haz the power, 2015-11-06 17:00:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-06 17:00:29]

Patchset 5 (id:??) landed as
https://crrev.com/d66daa2d2f9fe8ea2bd0e912e2d8c6c4f388f14e
Cr-Commit-Position: refs/heads/master@{#10542}