Fix for Win GN Build.

Fix for Win GN Build.

This changes it to inherit common configuration, in order to LOG() macro
take effect (hopefully).

This should fix the following errors:
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj.rsp /c ../../third_party/webrtc/sound/nullsoundsystem.cc /Foobj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj /Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\nullsoundsystem.cc(78) : error C3861: 'LOG': identifier not found
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj.rsp /c ../../third_party/webrtc/sound/platformsoundsystemfactory.cc /Foobj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj /Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\platformsoundsystemfactory.cc(29) : error C3861: 'LOG': identifier not found
ninja: build stopped: subcommand failed.

BUG=webrtc:4160
R=kjellander@webrtc.org
NOTRY=True

Committed: https://crrev.com/7ef0553c85c5b373535d7f6161e9a6d3b5b9a826
Cr-Commit-Position: refs/heads/master@{#10408}

[tfarina, 2015-10-26 13:31:42]

Description was changed from

==========
Fix for Win GN Build.

This changes it to inherit common configuration, in order to LOG() macro
take effect (hopefully).

BUG=webrtc:4160
R=kjellander@webrtc.org
==========

to

==========
Fix for Win GN Build.

This changes it to inherit common configuration, in order to LOG() macro
take effect (hopefully).

This should fix the following errors:
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj.rsp /c
../../third_party/webrtc/sound/nullsoundsystem.cc
/Foobj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj
/Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\nullsoundsystem.cc(78)
: error C3861: 'LOG': identifier not found
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj.rsp /c
../../third_party/webrtc/sound/platformsoundsystemfactory.cc
/Foobj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj
/Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\platformsoundsystemfactory.cc(29)
: error C3861: 'LOG': identifier not found
ninja: build stopped: subcommand failed.

BUG=webrtc:4160
R=kjellander@webrtc.org
==========

[tfarina, 2015-10-26 13:32:27]

Henrik, does this fixes the Win errors?

[tfarina, 2015-10-26 13:32:27]

Henrik, does this fixes the Win errors?

[kjellander_webrtc, 2015-10-26 13:44:22]

On 2015/10/26 13:32:27, tfarina wrote:
> Henrik, does this fixes the Win errors?

I can't say for sure but I think it should. Sorry for our bad trybot coverage
for changes like this. Let's try.

lgtm

[kjellander_webrtc, 2015-10-26 13:45:11]

Description was changed from

==========
Fix for Win GN Build.

This changes it to inherit common configuration, in order to LOG() macro
take effect (hopefully).

This should fix the following errors:
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj.rsp /c
../../third_party/webrtc/sound/nullsoundsystem.cc
/Foobj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj
/Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\nullsoundsystem.cc(78)
: error C3861: 'LOG': identifier not found
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj.rsp /c
../../third_party/webrtc/sound/platformsoundsystemfactory.cc
/Foobj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj
/Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\platformsoundsystemfactory.cc(29)
: error C3861: 'LOG': identifier not found
ninja: build stopped: subcommand failed.

BUG=webrtc:4160
R=kjellander@webrtc.org
==========

to

==========
Fix for Win GN Build.

This changes it to inherit common configuration, in order to LOG() macro
take effect (hopefully).

This should fix the following errors:
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj.rsp /c
../../third_party/webrtc/sound/nullsoundsystem.cc
/Foobj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj
/Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\nullsoundsystem.cc(78)
: error C3861: 'LOG': identifier not found
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj.rsp /c
../../third_party/webrtc/sound/platformsoundsystemfactory.cc
/Foobj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj
/Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb
e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\platformsoundsystemfactory.cc(29)
: error C3861: 'LOG': identifier not found
ninja: build stopped: subcommand failed.

BUG=webrtc:4160
R=kjellander@webrtc.org
NOTRY=True
==========

[kjellander_webrtc, 2015-10-26 13:46:39]

If possibly, don't simply push CQ dry-run on every WebRTC patch. We don't have
the same resources as Chromium so it has to be used with care.
With such a GN-only change, it's preferred to only use the *_gn_* bots.

I'm submitting this with NOTRY=True since it's currently blocking
chromium.webrtc.fyi

[kjellander_webrtc, 2015-10-26 13:46:43]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-10-26 13:46:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419413002/1

[commit-bot: I haz the power, 2015-10-26 13:48:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-26 13:48:18]

Patchset 1 (id:??) landed as
https://crrev.com/7ef0553c85c5b373535d7f6161e9a6d3b5b9a826
Cr-Commit-Position: refs/heads/master@{#10408}

[kjellander_webrtc, 2015-10-26 15:04:01]

On 2015/10/26 13:48:18, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7ef0553c85c5b373535d7f6161e9a6d3b5b9a826
> Cr-Commit-Position: refs/heads/master@{#10408}

This only fixes the Release builds. The Debug builds get this error now instead:

[4602/4804] SOLINK ./libcontent.so
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,--export-dynamic -o ./libcontent.so
-Wl,-soname=libcontent.so @./libcontent.so.rsp && { readelf -d ./libcontent.so |
grep SONAME ; nm -gD -f p ./libcontent.so | cut -f1-2 -d' '; } >
./libcontent.so.tmp && if ! cmp -s ./libcontent.so.tmp ./libcontent.so.TOC; then
mv ./libcontent.so.tmp ./libcontent.so.TOC; fi
../../third_party/webrtc/sound/alsasoundsystem.cc:453: error: undefined
reference to 'rtc::LateBindingSymbolTable::Load()'
../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined
reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined
reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined
reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined
reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
../../third_party/webrtc/base/latebindingsymboltable.cc.def:63: error: undefined
reference to
'rtc::LateBindingSymbolTable::LateBindingSymbolTable(rtc::LateBindingSymbolTable::TableInfo
const*, void**)'
../../third_party/webrtc/base/latebindingsymboltable.cc.def:65: error: undefined
reference to 'rtc::LateBindingSymbolTable::~LateBindingSymbolTable()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

from
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20GN%20%28dbg...

[kjellander_webrtc, 2015-10-26 15:05:37]

On 2015/10/26 15:04:01, kjellander (webrtc) wrote:
> On 2015/10/26 13:48:18, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/7ef0553c85c5b373535d7f6161e9a6d3b5b9a826
> > Cr-Commit-Position: refs/heads/master@{#10408}
> 
> This only fixes the Release builds. The Debug builds get this error now
instead:
> 
> [4602/4804] SOLINK ./libcontent.so
> FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared
> -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
> -Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
> -Wl,--icf=all -pthread -m64 -Wl,--export-dynamic -o ./libcontent.so
> -Wl,-soname=libcontent.so @./libcontent.so.rsp && { readelf -d ./libcontent.so
|
> grep SONAME ; nm -gD -f p ./libcontent.so | cut -f1-2 -d' '; } >
> ./libcontent.so.tmp && if ! cmp -s ./libcontent.so.tmp ./libcontent.so.TOC;
then
> mv ./libcontent.so.tmp ./libcontent.so.TOC; fi
> ../../third_party/webrtc/sound/alsasoundsystem.cc:453: error: undefined
> reference to 'rtc::LateBindingSymbolTable::Load()'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.cc.def:63: error:
undefined
> reference to
>
'rtc::LateBindingSymbolTable::LateBindingSymbolTable(rtc::LateBindingSymbolTable::TableInfo
> const*, void**)'
> ../../third_party/webrtc/base/latebindingsymboltable.cc.def:65: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::~LateBindingSymbolTable()'
> clang: error: linker command failed with exit code 1 (use -v to see
invocation)
> ninja: build stopped: subcommand failed.
> 
> from
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20GN%20%28dbg...

I suggest reverting all three CLs and work on a new one where you setup a
Chromium build for the patch before landing it.