Chromium Code Reviews

Issue 1419413002: Fix for Win GN Build. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix for Win GN Build. This changes it to inherit common configuration, in order to LOG() macro take effect (hopefully). This should fix the following errors: FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj.rsp /c ../../third_party/webrtc/sound/nullsoundsystem.cc /Foobj/third_party/webrtc/sound/rtc_sound/nullsoundsystem.obj /Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\nullsoundsystem.cc(78) : error C3861: 'LOG': identifier not found FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj.rsp /c ../../third_party/webrtc/sound/platformsoundsystemfactory.cc /Foobj/third_party/webrtc/sound/rtc_sound/platformsoundsystemfactory.obj /Fdobj/third_party/webrtc/sound/rtc_sound_cc.pdb e:\b\build\slave\win_gn\build\src\third_party\webrtc\sound\platformsoundsystemfactory.cc(29) : error C3861: 'LOG': identifier not found ninja: build stopped: subcommand failed. BUG=webrtc:4160 R=kjellander@webrtc.org NOTRY=True Committed: https://crrev.com/7ef0553c85c5b373535d7f6161e9a6d3b5b9a826 Cr-Commit-Position: refs/heads/master@{#10408}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+3 lines, -0 lines)
M webrtc/sound/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments

Messages

Total messages: 12 (3 generated)
tfarina
Henrik, does this fixes the Win errors?
5 years, 1 month ago (2015-10-26 13:32:27 UTC) #2
tfarina
Henrik, does this fixes the Win errors?
5 years, 1 month ago (2015-10-26 13:32:27 UTC) #3
kjellander_webrtc
On 2015/10/26 13:32:27, tfarina wrote: > Henrik, does this fixes the Win errors? I can't ...
5 years, 1 month ago (2015-10-26 13:44:22 UTC) #4
kjellander_webrtc
If possibly, don't simply push CQ dry-run on every WebRTC patch. We don't have the ...
5 years, 1 month ago (2015-10-26 13:46:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419413002/1
5 years, 1 month ago (2015-10-26 13:46:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 13:48:07 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7ef0553c85c5b373535d7f6161e9a6d3b5b9a826 Cr-Commit-Position: refs/heads/master@{#10408}
5 years, 1 month ago (2015-10-26 13:48:18 UTC) #10
kjellander_webrtc
On 2015/10/26 13:48:18, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 1 month ago (2015-10-26 15:04:01 UTC) #11
kjellander_webrtc
5 years, 1 month ago (2015-10-26 15:05:37 UTC) #12
Message was sent while issue was closed. 
On 2015/10/26 15:04:01, kjellander (webrtc) wrote:
> On 2015/10/26 13:48:18, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/7ef0553c85c5b373535d7f6161e9a6d3b5b9a826
> > Cr-Commit-Position: refs/heads/master@{#10408}
> 
> This only fixes the Release builds. The Debug builds get this error now
instead:
> 
> [4602/4804] SOLINK ./libcontent.so
> FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared
> -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
> -Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
> -Wl,--icf=all -pthread -m64 -Wl,--export-dynamic -o ./libcontent.so
> -Wl,-soname=libcontent.so @./libcontent.so.rsp && { readelf -d ./libcontent.so
|
> grep SONAME ; nm -gD -f p ./libcontent.so | cut -f1-2 -d' '; } >
> ./libcontent.so.tmp && if ! cmp -s ./libcontent.so.tmp ./libcontent.so.TOC;
then
> mv ./libcontent.so.tmp ./libcontent.so.TOC; fi
> ../../third_party/webrtc/sound/alsasoundsystem.cc:453: error: undefined
> reference to 'rtc::LateBindingSymbolTable::Load()'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::IsLoaded() const'
> ../../third_party/webrtc/base/latebindingsymboltable.cc.def:63: error:
undefined
> reference to
>
'rtc::LateBindingSymbolTable::LateBindingSymbolTable(rtc::LateBindingSymbolTable::TableInfo
> const*, void**)'
> ../../third_party/webrtc/base/latebindingsymboltable.cc.def:65: error:
undefined
> reference to 'rtc::LateBindingSymbolTable::~LateBindingSymbolTable()'
> clang: error: linker command failed with exit code 1 (use -v to see
invocation)
> ninja: build stopped: subcommand failed.
> 
> from
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20GN%20%28dbg...

I suggest reverting all three CLs and work on a new one where you setup a
Chromium build for the patch before landing it.

Powered by Google App Engine