Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1419023003: Create isolate files for nonparallel tests. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Create isolate files for nonparallel tests. Adds missing Android things for webrtc_nonparallel_tests. BUG=chromium:445880 R=kjellander@webrtc.org Committed: https://crrev.com/4f4f756f6ff50d4142990c15fc656713d452c22b Cr-Commit-Position: refs/heads/master@{#10451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M webrtc/build/android/test_runner.py View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/build/apk_tests_noop.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
A + webrtc/webrtc_nonparallel_tests.isolate View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pbos-webrtc
PTAL
5 years, 1 month ago (2015-10-29 14:23:23 UTC) #1
kjellander_webrtc
lgtm
5 years, 1 month ago (2015-10-29 14:26:41 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as 4f4f756f6ff50d4142990c15fc656713d452c22b (presubmit successful).
5 years, 1 month ago (2015-10-29 14:29:24 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 14:29:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f4f756f6ff50d4142990c15fc656713d452c22b
Cr-Commit-Position: refs/heads/master@{#10451}

Powered by Google App Engine
This is Rietveld 408576698