common_video: rename interface -> include

common_video: rename interface -> include

To avoid breaking downstream, the "interface" directories were copied
into a new "common_video/include" dir. The old headers got pragma
warnings added about deprecation (a very short deprecation since I plan
to remove them as soon downstream is updated).
The header guards are also identical to avoid mixing them up in the transition.

BUG=webrtc:5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc

Committed: https://crrev.com/6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f
Cr-Commit-Position: refs/heads/master@{#10659}

[kjellander_webrtc, 2015-11-08 19:30:18]

kjellander@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2015-11-16 18:11:10]

lgtm

[kjellander_webrtc, 2015-11-16 18:47:14]

kjellander@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kjellander_webrtc, 2015-11-16 18:47:14]

+tommi for root OWNERS rubberstamp

[tommi, 2015-11-16 20:18:49]

rs lgtm

[tommi, 2015-11-16 20:18:54]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2015-11-16 20:18:55]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1418913006/#ps20001 (title:
"Rebased")

[commit-bot: I haz the power, 2015-11-16 20:19:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418913006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418913006/20001

[kjellander_webrtc, 2015-11-16 20:47:36]

Description was changed from

==========
common_video: rename interface -> include

To avoid breaking downstream, the "interface" directories were copied
into a new "common_video/include" dir. The old headers got pragma
warnings added about deprecation (a very short deprecation since I plan
to remove them as soon downstream is updated).
The header guards are also identical to avoid mixing them up in the transition.

BUG=webrtc:5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

to

==========
common_video: rename interface -> include

To avoid breaking downstream, the "interface" directories were copied
into a new "common_video/include" dir. The old headers got pragma
warnings added about deprecation (a very short deprecation since I plan
to remove them as soon downstream is updated).
The header guards are also identical to avoid mixing them up in the transition.

BUG=webrtc:5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

[commit-bot: I haz the power, 2015-11-16 21:52:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-16 21:52:45]

Patchset 2 (id:??) landed as
https://crrev.com/6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f
Cr-Commit-Position: refs/heads/master@{#10659}

[alancutter (OOO until 2018), 2015-11-17 22:34:06]

On 2015/11/16 at 21:52:45, commit-bot wrote:
> Patchset 2 (id:??) landed as
https://crrev.com/6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f
> Cr-Commit-Position: refs/heads/master@{#10659}

I'm getting a warning when compiling Chromium:


    In file included from
../../content/renderer/media/webrtc/webrtc_video_frame_adapter.cc:5:
    In file included from
../../content/renderer/media/webrtc/webrtc_video_frame_adapter.h:9:
    ../../third_party/webrtc/common_video/interface/video_frame_buffer.h:14:9:
warning: WARNING: common_video/include is DEPRECATED; use common_video/include
[-W#pragma-messages]
    #pragma message("WARNING: common_video/include is DEPRECATED; use
common_video/include")
            ^
    1 warning generated.


Is this warning correct? It seems to contradict itself.

[Dirk Pranke, 2015-11-18 01:38:11]

On 2015/11/17 22:34:06, alancutter wrote:
> On 2015/11/16 at 21:52:45, commit-bot wrote:
> > Patchset 2 (id:??) landed as
> https://crrev.com/6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f
> > Cr-Commit-Position: refs/heads/master@{#10659}
> 
> I'm getting a warning when compiling Chromium:
> 
> 
>     In file included from
> ../../content/renderer/media/webrtc/webrtc_video_frame_adapter.cc:5:
>     In file included from
> ../../content/renderer/media/webrtc/webrtc_video_frame_adapter.h:9:
>     ../../third_party/webrtc/common_video/interface/video_frame_buffer.h:14:9:
> warning: WARNING: common_video/include is DEPRECATED; use common_video/include
> [-W#pragma-messages]
>     #pragma message("WARNING: common_video/include is DEPRECATED; use
> common_video/include")
>             ^
>     1 warning generated.
> 
> 
> Is this warning correct? It seems to contradict itself.

+1 to alancutter's question; also I'm wondering why we didn't update the calling
code in Chromium as part of the roll? Is there some other plan?

[Dirk Pranke, 2015-11-18 01:38:47]

Description was changed from

==========
common_video: rename interface -> include

To avoid breaking downstream, the "interface" directories were copied
into a new "common_video/include" dir. The old headers got pragma
warnings added about deprecation (a very short deprecation since I plan
to remove them as soon downstream is updated).
The header guards are also identical to avoid mixing them up in the transition.

BUG=webrtc:5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc

Committed: https://crrev.com/6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f
Cr-Commit-Position: refs/heads/master@{#10659}
==========

to

==========
common_video: rename interface -> include

To avoid breaking downstream, the "interface" directories were copied
into a new "common_video/include" dir. The old headers got pragma
warnings added about deprecation (a very short deprecation since I plan
to remove them as soon downstream is updated).
The header guards are also identical to avoid mixing them up in the transition.

BUG=webrtc:5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc

Committed: https://crrev.com/6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f
Cr-Commit-Position: refs/heads/master@{#10659}
==========

[Matt Giuca, 2015-11-18 03:18:52]

mgiuca@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-11-18 03:18:53]

https://codereview.webrtc.org/1418913006/diff/20001/webrtc/common_video/inter...
File webrtc/common_video/interface/video_frame_buffer.h (right):

https://codereview.webrtc.org/1418913006/diff/20001/webrtc/common_video/inter...
webrtc/common_video/interface/video_frame_buffer.h:14: #pragma message("WARNING:
common_video/include is DEPRECATED; use common_video/include")
This is spamming the Chrome build logs. Please remove or fix usages of it.

Also it makes no sense. Is it supposed to say "common_video/interface is
deprecated"?

[kjellander_webrtc, 2015-11-18 06:38:13]

On 2015/11/18 01:38:11, Dirk Pranke wrote:
> On 2015/11/17 22:34:06, alancutter wrote:
> > On 2015/11/16 at 21:52:45, commit-bot wrote:
> > > Patchset 2 (id:??) landed as
> > https://crrev.com/6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f
> > > Cr-Commit-Position: refs/heads/master@{#10659}
> > 
> > I'm getting a warning when compiling Chromium:
> > 
> > 
> >     In file included from
> > ../../content/renderer/media/webrtc/webrtc_video_frame_adapter.cc:5:
> >     In file included from
> > ../../content/renderer/media/webrtc/webrtc_video_frame_adapter.h:9:
> >    
../../third_party/webrtc/common_video/interface/video_frame_buffer.h:14:9:
> > warning: WARNING: common_video/include is DEPRECATED; use
common_video/include
> > [-W#pragma-messages]
> >     #pragma message("WARNING: common_video/include is DEPRECATED; use
> > common_video/include")
> >             ^
> >     1 warning generated.
> > 
> > 
> > Is this warning correct? It seems to contradict itself.
> 
> +1 to alancutter's question; also I'm wondering why we didn't update the
calling
> code in Chromium as part of the roll? Is there some other plan?

It surely contradicts itself and that's my mistake. I should have communicated
with our sheriff performing the roll to get it fixed in the same CL. Sorry about
that. I'm fixing it in https://codereview.chromium.org/1454053002/

[kjellander_webrtc, 2015-11-18 06:38:27]

Fixing in https://codereview.chromium.org/1454053002/

https://codereview.webrtc.org/1418913006/diff/20001/webrtc/common_video/inter...
File webrtc/common_video/interface/video_frame_buffer.h (right):

https://codereview.webrtc.org/1418913006/diff/20001/webrtc/common_video/inter...
webrtc/common_video/interface/video_frame_buffer.h:14: #pragma message("WARNING:
common_video/include is DEPRECATED; use common_video/include")
On 2015/11/18 03:18:52, Matt Giuca wrote:
> This is spamming the Chrome build logs. Please remove or fix usages of it.

I don't consider one warning emitted during compilation being spamming, it's
rather the warning serving it's purpose (getting the include fixed).
I'm updating this in https://codereview.chromium.org/1454053002/ which should
make it go away.

> 
> Also it makes no sense. Is it supposed to say "common_video/interface is
> deprecated"?

Yeah, I don't know how that happened :P