Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1418753002: Move i420 files to the right location (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move i420 files to the right location There's also a presubmit check that disallows .. references in GYP files, which this solves. BUG=webrtc:5095 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/a74c08dcedf38f7fb7bf75f01e7dff93148e5b66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -429 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/i420/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/i420/i420.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_coding/codecs/i420/i420.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_coding/codecs/i420/include/i420.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/main/interface/i420.h View 1 chunk +0 lines, -157 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/main/source/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/main/source/i420.cc View 1 chunk +0 lines, -240 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/main/source/i420.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
5 years, 2 months ago (2015-10-21 06:41:25 UTC) #3
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-22 09:35:01 UTC) #4
kjellander_webrtc
Committed patchset #1 (id:1) manually as a74c08dcedf38f7fb7bf75f01e7dff93148e5b66 (presubmit successful).
5 years, 2 months ago (2015-10-22 10:23:29 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 10:23:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a74c08dcedf38f7fb7bf75f01e7dff93148e5b66
Cr-Commit-Position: refs/heads/master@{#10371}

Powered by Google App Engine
This is Rietveld 408576698