Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1418613002: ChannelGroup cleanup. (Closed)

Created:
5 years, 2 months ago by mflodman
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ChannelGroup cleanup. Move CallStats to Call, EncoderStateFeedback to VideoSendStream and remove last ViEChannel dependency from ChannelGroup. BUG=webrtc:5079 R=pbos@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/e37870297fc45f1253dff4b1c59c85a50d2a8a97 Cr-Commit-Position: refs/heads/master@{#10355}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -68 lines) Patch
M webrtc/call/call.cc View 7 chunks +10 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 4 chunks +11 lines, -15 lines 0 comments Download
M webrtc/video/video_send_stream.h View 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 7 chunks +13 lines, -10 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 3 chunks +6 lines, -9 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 1 8 chunks +7 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
mflodman
Some more cleanup of ChannelGroup. I chose to not rename the class in the same ...
5 years, 2 months ago (2015-10-20 11:39:27 UTC) #2
pbos-webrtc
lgtm
5 years, 2 months ago (2015-10-20 12:31:34 UTC) #3
stefan-webrtc
lgtm https://codereview.webrtc.org/1418613002/diff/1/webrtc/video_engine/vie_channel_group.cc File webrtc/video_engine/vie_channel_group.cc (right): https://codereview.webrtc.org/1418613002/diff/1/webrtc/video_engine/vie_channel_group.cc#newcode258 webrtc/video_engine/vie_channel_group.cc:258: rtp_module->SetREMBStatus(sender || receiver); Looks like this could be ...
5 years, 2 months ago (2015-10-21 11:16:45 UTC) #4
mflodman
https://codereview.webrtc.org/1418613002/diff/1/webrtc/video_engine/vie_channel_group.cc File webrtc/video_engine/vie_channel_group.cc (right): https://codereview.webrtc.org/1418613002/diff/1/webrtc/video_engine/vie_channel_group.cc#newcode258 webrtc/video_engine/vie_channel_group.cc:258: rtp_module->SetREMBStatus(sender || receiver); On 2015/10/21 11:16:45, stefan-webrtc (holmer) wrote: ...
5 years, 2 months ago (2015-10-21 11:24:19 UTC) #5
mflodman
Committed patchset #2 (id:20001) manually as e37870297fc45f1253dff4b1c59c85a50d2a8a97 (presubmit successful).
5 years, 2 months ago (2015-10-21 11:24:42 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 11:24:45 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e37870297fc45f1253dff4b1c59c85a50d2a8a97
Cr-Commit-Position: refs/heads/master@{#10355}

Powered by Google App Engine
This is Rietveld 408576698