Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1418563005: SurfaceTextureHelper: Remove use of quitSafely() because it's API lvl 18 (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

SurfaceTextureHelper: Remove use of quitSafely() because it's API lvl 18 There is no reason to not just quit() in release(). Committed: https://crrev.com/401fb0648a262b9fe3981f9e2957cbca6682cb9b Cr-Commit-Position: refs/heads/master@{#10394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M talk/app/webrtc/java/android/org/webrtc/SurfaceTextureHelper.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 2 months ago (2015-10-23 16:10:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418563005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418563005/1
5 years, 2 months ago (2015-10-24 00:31:23 UTC) #6
perkj_webrtc
On 2015/10/23 16:10:33, magjed_webrtc wrote: > perkj - Please take a look. lgtm
5 years, 2 months ago (2015-10-24 00:31:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-24 01:17:55 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-24 01:18:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/401fb0648a262b9fe3981f9e2957cbca6682cb9b
Cr-Commit-Position: refs/heads/master@{#10394}

Powered by Google App Engine
This is Rietveld 408576698