webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc - Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc

Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc ('k') | webrtc/modules/audio_coding/neteq/tools/audio_loop.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc

diff --git a/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc b/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc

index 422a9fa6ebe619d3dfa9772f9b0a6b1ba4c9ee03..01c3964557bd1bfb7877c0e8afda748fedad4934 100644

--- a/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc

+++ b/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc

@@ -66,8 +66,10 @@ class NetEqPcmuQualityTest : public NetEqQualityTest {

uint32_t dummy_timestamp = 0;

AudioEncoder::EncodedInfo info;

do {

- info = encoder_->Encode(dummy_timestamp, &in_data[encoded_samples],

- kFrameSizeSamples, max_bytes, payload);

+ info = encoder_->Encode(dummy_timestamp,

+ rtc::ArrayView<const int16_t>(

+ in_data + encoded_samples, kFrameSizeSamples),

+ max_bytes, payload);

encoded_samples += kFrameSizeSamples;

} while (info.encoded_bytes == 0);

return rtc::checked_cast<int>(info.encoded_bytes);