webrtc/modules/audio_coding/neteq/neteq_unittest.cc - Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_unittest.cc

Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc ('k') | webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/neteq_unittest.cc

diff --git a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

index 4340f5497502f91bb5a5e801d725cabc7775203f..6f47dd1c06135486de67d52bb683e73eec922bf2 100644

--- a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

+++ b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

@@ -939,8 +939,10 @@ class NetEqBgnTest : public NetEqDecodingTest {

uint32_t receive_timestamp = 0;

for (int n = 0; n < 10; ++n) { // Insert few packets and get audio.

- size_t enc_len_bytes = WebRtcPcm16b_Encode(

- input.GetNextBlock(), expected_samples_per_channel, payload);

+ auto block = input.GetNextBlock();

+ ASSERT_EQ(expected_samples_per_channel, block.size());

+ size_t enc_len_bytes =

+ WebRtcPcm16b_Encode(block.data(), block.size(), payload);

ASSERT_EQ(enc_len_bytes, expected_samples_per_channel * 2);

number_channels = 0;