webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h - Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h

Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h ('k') | webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h

diff --git a/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h b/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h

index 279f80d6fc97cb7b0b4cca6464bf3080e7f3c96d..4cfd7824b76733ec8a245ef49fdd0c188cb740df 100644

--- a/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h

+++ b/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h

@@ -115,7 +115,7 @@ int AudioEncoderIsacT<T>::GetTargetBitrate() const {

template <typename T>

AudioEncoder::EncodedInfo AudioEncoderIsacT<T>::EncodeInternal(

uint32_t rtp_timestamp,

- const int16_t* audio,

+ rtc::ArrayView<const int16_t> audio,

size_t max_encoded_bytes,

uint8_t* encoded) {

if (!packet_in_progress_) {

@@ -127,7 +127,7 @@ AudioEncoder::EncodedInfo AudioEncoderIsacT<T>::EncodeInternal(

IsacBandwidthInfo bwinfo = bwinfo_->Get();

T::SetBandwidthInfo(isac_state_, &bwinfo);

}

- int r = T::Encode(isac_state_, audio, encoded);

+ int r = T::Encode(isac_state_, audio.data(), encoded);

RTC_CHECK_GE(r, 0) << "Encode failed (error code "

<< T::GetErrorCode(isac_state_) << ")";