webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc - Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: disconvert to bool Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/base/array_view_unittest.cc ('K') | « webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc ('k') | webrtc/modules/audio_coding/codecs/cng/include/audio_encoder_cng.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

diff --git a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

index 0b837a0f12b1e909d1d91de3655c056ea3907c3c..ec3f6330b8cc032b5d7c3dee89f6673fe07ac732 100644

--- a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

+++ b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

@@ -75,8 +75,10 @@ class AudioEncoderCngTest : public ::testing::Test {

void Encode() {

ASSERT_TRUE(cng_) << "Must call CreateCng() first.";

- encoded_info_ = cng_->Encode(timestamp_, audio_, num_audio_samples_10ms_,

- encoded_.size(), &encoded_[0]);

+ encoded_info_ = cng_->Encode(

+ timestamp_,

+ rtc::ArrayView<const int16_t>(audio_, num_audio_samples_10ms_),

+ encoded_.size(), &encoded_[0]);

timestamp_ += static_cast<uint32_t>(num_audio_samples_10ms_);

}