webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc - Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

Issue 1418423010: Pass audio to AudioEncoder::Encode() in an ArrayView (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc ('K') | « webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc ('k') | webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

index dfd777c7ad0be3e521ed8ef074cc26b38ff87c54..14743956babd05c2374776679b68e5fb28d443dc 100644

--- a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

+++ b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

@@ -149,7 +149,9 @@ int32_t AudioCodingModuleImpl::Encode(const InputData& input_data) {

encode_buffer_.SetSize(audio_encoder->MaxEncodedBytes());

encoded_info = audio_encoder->Encode(

- rtp_timestamp, input_data.audio, input_data.length_per_channel,

+ rtp_timestamp, rtc::ArrayView<const int16_t>(

+ input_data.audio, input_data.audio_channel *

+ input_data.length_per_channel),

encode_buffer_.size(), encode_buffer_.data());

encode_buffer_.SetSize(encoded_info.encoded_bytes);

bitrate_logger_.MaybeLog(audio_encoder->GetTargetBitrate() / 1000);