Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Issue 1418423003: Use webrtc/base/checks.h in desktop_capture. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use webrtc/base/checks.h in desktop_capture. Collided with CHECKs included in logging headers. BUG=webrtc:5118 R=mflodman@webrtc.org Committed: https://crrev.com/4f847da5a004ae18a5527232d8e982fe0d4cb77d Cr-Commit-Position: refs/heads/master@{#10425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pbos-webrtc
PTAL
5 years, 1 month ago (2015-10-26 17:50:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418423003/1
5 years, 1 month ago (2015-10-26 18:06:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 20:01:13 UTC) #6
mflodman
LGTM
5 years, 1 month ago (2015-10-27 06:49:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418423003/1
5 years, 1 month ago (2015-10-27 10:42:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 10:43:08 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 10:43:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f847da5a004ae18a5527232d8e982fe0d4cb77d
Cr-Commit-Position: refs/heads/master@{#10425}

Powered by Google App Engine
This is Rietveld 408576698