Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1418223002: SurfaceViewRenderer: Remove use of quitSafely() because it's API lvl 18 (Closed)

Created:
5 years, 1 month ago by magjed_webrtc
Modified:
5 years, 1 month ago
Reviewers:
perkj_webrtc
CC:
onedays77_gmail.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

SurfaceViewRenderer: Remove use of quitSafely() because it's API lvl 18 I replaced quitSafely() with a CountDownLatch. The reason for not using ThreadUtils.invokeUninterruptibly() is that I want to stop accepting frames asap, and invokeUninterruptibly() would still accept frames during the waiting time. BUG=webrtc:4742 Committed: https://crrev.com/238b15d54395df53d2219dc12a91e3bfd9c6fa23 Cr-Commit-Position: refs/heads/master@{#10393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 1 month ago (2015-10-23 16:14:03 UTC) #3
perkj_webrtc
On 2015/10/23 16:14:03, magjed_webrtc wrote: > perkj - Please take a look. lgtm
5 years, 1 month ago (2015-10-24 00:30:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418223002/1
5 years, 1 month ago (2015-10-24 00:30:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/8875)
5 years, 1 month ago (2015-10-24 00:33:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418223002/1
5 years, 1 month ago (2015-10-24 00:59:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-24 01:14:27 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-24 01:14:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/238b15d54395df53d2219dc12a91e3bfd9c6fa23
Cr-Commit-Position: refs/heads/master@{#10393}

Powered by Google App Engine
This is Rietveld 408576698