Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1418213005: UBSan: Add blacklist files for WebRTC standalone. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

UBSan: Add blacklist files for WebRTC standalone. For more info, see http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer BUG=webrtc:5124 TESTED=Passing compilation using: GYP_DEFINES="ubsan=1" webrtc/build/gyp_webrtc && ninja -C out/Release GYP_DEFINES="ubsan_vptr=1" webrtc/build/gyp_webrtc && ninja -C out/Release R=pbos@webrtc.org Committed: https://crrev.com/f1dcd46a9b8e9c665ccd4c2c07ba1497683ac001 Cr-Commit-Position: refs/heads/master@{#10429}

Patch Set 1 #

Patch Set 2 : Add tools/ubsan/vptr_blacklist.txt #

Patch Set 3 : Add comment and OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, --1 lines) Patch
A + tools/ubsan/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/ubsan/blacklist.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A tools/ubsan/vptr_blacklist.txt View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
Bots are now online in http://build.chromium.org/p/client.webrtc.fyi/waterfall and they need this to pass compile.
5 years, 1 month ago (2015-10-27 13:50:57 UTC) #5
pbos-webrtc
Feel free to format the comments in here as tools/msan/blacklist.txt and especially mention: # Please ...
5 years, 1 month ago (2015-10-27 14:08:19 UTC) #6
kjellander_webrtc
Committed patchset #3 (id:40001) manually as f1dcd46a9b8e9c665ccd4c2c07ba1497683ac001 (presubmit successful).
5 years, 1 month ago (2015-10-27 14:32:02 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 14:32:05 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1dcd46a9b8e9c665ccd4c2c07ba1497683ac001
Cr-Commit-Position: refs/heads/master@{#10429}

Powered by Google App Engine
This is Rietveld 408576698