Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1418133012: Disable denoising for VP9 by default. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/media/webrtc/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 1643 matching lines...) Expand 10 before | Expand all | Expand 10 after
1654 1654
1655 cricket::FakeVideoCapturer capturer; 1655 cricket::FakeVideoCapturer capturer;
1656 capturer.SetScreencast(false); 1656 capturer.SetScreencast(false);
1657 EXPECT_EQ(cricket::CS_RUNNING, 1657 EXPECT_EQ(cricket::CS_RUNNING,
1658 capturer.Start(capturer.GetSupportedFormats()->front())); 1658 capturer.Start(capturer.GetSupportedFormats()->front()));
1659 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, &capturer)); 1659 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, &capturer));
1660 channel_->SetSend(true); 1660 channel_->SetSend(true);
1661 1661
1662 EXPECT_TRUE(capturer.CaptureFrame()); 1662 EXPECT_TRUE(capturer.CaptureFrame());
1663 1663
1664 webrtc::VideoCodecVP8 vp8_settings;
1665 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
1666 EXPECT_TRUE(vp8_settings.denoisingOn)
1667 << "VP8 denoising should be on by default.";
1668
1664 stream = SetDenoisingOption(parameters, false); 1669 stream = SetDenoisingOption(parameters, false);
1665 1670
1666 webrtc::VideoCodecVP8 vp8_settings;
1667 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set."; 1671 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
1668 EXPECT_FALSE(vp8_settings.denoisingOn); 1672 EXPECT_FALSE(vp8_settings.denoisingOn);
1669 EXPECT_TRUE(vp8_settings.automaticResizeOn); 1673 EXPECT_TRUE(vp8_settings.automaticResizeOn);
1670 EXPECT_TRUE(vp8_settings.frameDroppingOn); 1674 EXPECT_TRUE(vp8_settings.frameDroppingOn);
1671 1675
1672 stream = SetDenoisingOption(parameters, true); 1676 stream = SetDenoisingOption(parameters, true);
1673 1677
1674 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set."; 1678 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
1675 EXPECT_TRUE(vp8_settings.denoisingOn); 1679 EXPECT_TRUE(vp8_settings.denoisingOn);
1676 EXPECT_TRUE(vp8_settings.automaticResizeOn); 1680 EXPECT_TRUE(vp8_settings.automaticResizeOn);
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
1742 1746
1743 cricket::FakeVideoCapturer capturer; 1747 cricket::FakeVideoCapturer capturer;
1744 capturer.SetScreencast(false); 1748 capturer.SetScreencast(false);
1745 EXPECT_EQ(cricket::CS_RUNNING, 1749 EXPECT_EQ(cricket::CS_RUNNING,
1746 capturer.Start(capturer.GetSupportedFormats()->front())); 1750 capturer.Start(capturer.GetSupportedFormats()->front()));
1747 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, &capturer)); 1751 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, &capturer));
1748 channel_->SetSend(true); 1752 channel_->SetSend(true);
1749 1753
1750 EXPECT_TRUE(capturer.CaptureFrame()); 1754 EXPECT_TRUE(capturer.CaptureFrame());
1751 1755
1756 webrtc::VideoCodecVP9 vp9_settings;
1757 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
1758 EXPECT_FALSE(vp9_settings.denoisingOn)
1759 << "VP9 denoising should be off by default.";
1760
1752 stream = SetDenoisingOption(parameters, false); 1761 stream = SetDenoisingOption(parameters, false);
1753 1762
1754 webrtc::VideoCodecVP9 vp9_settings;
1755 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set."; 1763 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
1756 EXPECT_FALSE(vp9_settings.denoisingOn); 1764 EXPECT_FALSE(vp9_settings.denoisingOn);
1757 // Frame dropping always on for real time video. 1765 // Frame dropping always on for real time video.
1758 EXPECT_TRUE(vp9_settings.frameDroppingOn); 1766 EXPECT_TRUE(vp9_settings.frameDroppingOn);
1759 1767
1760 stream = SetDenoisingOption(parameters, true); 1768 stream = SetDenoisingOption(parameters, true);
1761 1769
1762 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set."; 1770 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
1763 EXPECT_TRUE(vp9_settings.denoisingOn); 1771 EXPECT_TRUE(vp9_settings.denoisingOn);
1764 EXPECT_TRUE(vp9_settings.frameDroppingOn); 1772 EXPECT_TRUE(vp9_settings.frameDroppingOn);
(...skipping 1461 matching lines...) Expand 10 before | Expand all | Expand 10 after
3226 // Ensures that the correct settings are applied to the codec when two temporal 3234 // Ensures that the correct settings are applied to the codec when two temporal
3227 // layer screencasting is enabled, and that the correct simulcast settings are 3235 // layer screencasting is enabled, and that the correct simulcast settings are
3228 // reapplied when disabling screencasting. 3236 // reapplied when disabling screencasting.
3229 TEST_F(WebRtcVideoChannel2SimulcastTest, 3237 TEST_F(WebRtcVideoChannel2SimulcastTest,
3230 DISABLED_TwoTemporalLayerScreencastSettings) { 3238 DISABLED_TwoTemporalLayerScreencastSettings) {
3231 // TODO(pbos): Implement. 3239 // TODO(pbos): Implement.
3232 FAIL() << "Not implemented."; 3240 FAIL() << "Not implemented.";
3233 } 3241 }
3234 3242
3235 } // namespace cricket 3243 } // namespace cricket
OLDNEW
« no previous file with comments | « talk/media/webrtc/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698