Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1418063002: GN: Remove build_overrides/v8.gni (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Remove build_overrides/v8.gni After https://codereview.chromium.org/1413893003 this workaround is no longer needed (since we've now rolled that revision into WebRTC). BUG=541791 R=phoglund@webrtc.org Committed: https://crrev.com/48e66b4463a23a0736776896c8adfecc8f4c6ea8 Cr-Commit-Position: refs/heads/master@{#10370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
D build_overrides/v8.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
5 years, 2 months ago (2015-10-22 06:01:49 UTC) #3
phoglund
lgtm
5 years, 2 months ago (2015-10-22 07:15:59 UTC) #4
kjellander_webrtc
Committed patchset #1 (id:1) manually as 48e66b4463a23a0736776896c8adfecc8f4c6ea8 (presubmit successful).
5 years, 2 months ago (2015-10-22 08:50:49 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 08:50:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48e66b4463a23a0736776896c8adfecc8f4c6ea8
Cr-Commit-Position: refs/heads/master@{#10370}

Powered by Google App Engine
This is Rietveld 408576698