webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h - Issue 1417723005: Prevent BWE rampdowns without new loss reports.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

Issue 1417723005: Prevent BWE rampdowns without new loss reports. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc » ('j') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 *	9 *

10 * FEC and NACK added bitrate is handled outside class	10 * FEC and NACK added bitrate is handled outside class

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62	62

63 // incoming filters	63 // incoming filters

64 int accumulate_lost_packets_Q8_;	64 int accumulate_lost_packets_Q8_;

65 int accumulate_expected_packets_;	65 int accumulate_expected_packets_;

66	66

67 uint32_t bitrate_;	67 uint32_t bitrate_;

68 uint32_t min_bitrate_configured_;	68 uint32_t min_bitrate_configured_;

69 uint32_t max_bitrate_configured_;	69 uint32_t max_bitrate_configured_;

70 int64_t last_low_bitrate_log_ms_;	70 int64_t last_low_bitrate_log_ms_;

71	71

	72 bool has_decreased_since_last_fraction_loss_;

72 int64_t time_last_receiver_block_ms_;	73 int64_t time_last_receiver_block_ms_;

73 uint8_t last_fraction_loss_;	74 uint8_t last_fraction_loss_;

74 int64_t last_round_trip_time_ms_;	75 int64_t last_round_trip_time_ms_;

75	76

76 uint32_t bwe_incoming_;	77 uint32_t bwe_incoming_;

77 int64_t time_last_decrease_ms_;	78 int64_t time_last_decrease_ms_;

78 int64_t first_report_time_ms_;	79 int64_t first_report_time_ms_;

79 int initially_lost_packets_;	80 int initially_lost_packets_;

80 int bitrate_at_2_seconds_kbps_;	81 int bitrate_at_2_seconds_kbps_;

81 UmaState uma_update_state_;	82 UmaState uma_update_state_;

82 std::vector<bool> rampup_uma_stats_updated_;	83 std::vector<bool> rampup_uma_stats_updated_;

83 };	84 };

84 } // namespace webrtc	85 } // namespace webrtc

85 #endif // WEBRTC_MODULES_BITRATE_CONTROLLER_SEND_SIDE_BANDWIDTH_ESTIMATION_H_	86 #endif // WEBRTC_MODULES_BITRATE_CONTROLLER_SEND_SIDE_BANDWIDTH_ESTIMATION_H_

OLD	NEW