Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1417543002: Added override keyword to overridden methods to stop compiler warnings. (Closed)

Created:
5 years, 2 months ago by rlester
Modified:
5 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added override keyword to overridden methods to stop compiler warnings. BUG= Committed: https://crrev.com/ec9d187f708933c75c3b48cf62296c37c7c506d9 Cr-Commit-Position: refs/heads/master@{#10433}

Patch Set 1 #

Patch Set 2 : Remove virtual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -39 lines) Patch
M talk/media/webrtc/webrtcvideoframe.h View 1 3 chunks +36 lines, -34 lines 0 comments Download
M talk/session/media/channel.h View 1 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
rlester
5 years, 2 months ago (2015-10-19 15:58:11 UTC) #3
pthatcher1
lgtm
5 years, 2 months ago (2015-10-20 21:23:50 UTC) #4
rlester
On 2015/10/20 21:23:50, pthatcher1 wrote: > lgtm Thanks. I don't think I have commit access, ...
5 years, 2 months ago (2015-10-20 21:39:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417543002/20001
5 years, 2 months ago (2015-10-20 22:19:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-10-20 23:37:21 UTC) #9
rlester
On 2015/10/20 23:37:21, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-10-27 20:19:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417543002/20001
5 years, 1 month ago (2015-10-27 21:21:11 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 21:22:21 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 21:22:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec9d187f708933c75c3b48cf62296c37c7c506d9
Cr-Commit-Position: refs/heads/master@{#10433}

Powered by Google App Engine
This is Rietveld 408576698