Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417173004: audio_coding: rename interface -> include (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
tommi, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

audio_coding: rename interface -> include BUG=webrtc:5095 R=henrik.lundin@webrtc.org TBR=tommi@webrtc.org Committed: https://crrev.com/74640895fafbb90a6630a6a91b80da0a7cff229c Cr-Commit-Position: refs/heads/master@{#10444}

Patch Set 1 #

Total comments: 30

Patch Set 2 : Updated header guards #

Patch Set 3 : Restored incorrectly renamed header guards and fixed an old error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -3637 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 9 chunks +17 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_decoder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/include/webrtc_cng.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/include/g711_interface.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/include/g722_interface.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/ilbc.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/ilbc/include/audio_encoder_ilbc.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/ilbc/include/ilbc.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/interface/audio_decoder_ilbc.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/interface/audio_encoder_ilbc.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/interface/ilbc.h View 1 chunk +0 lines, -258 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_decoder_isac_t_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/fix/include/audio_decoder_isacfix.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/fix/include/audio_encoder_isacfix.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/fix/include/isacfix.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/fix/interface/audio_decoder_isacfix.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/fix/interface/audio_encoder_isacfix.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/fix/interface/isacfix.h View 1 chunk +0 lines, -637 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/audio_decoder_isacfix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/audio_encoder_isacfix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/isac_fix_type.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/test/isac_speed_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac_test.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isacfix.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isacfix_test.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/main/include/audio_decoder_isac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/main/include/audio_encoder_isac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/main/include/isac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/main/interface/audio_decoder_isac.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/main/interface/audio_encoder_isac.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/main/interface/isac.h View 1 chunk +0 lines, -724 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/audio_decoder_isac.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/isac.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/isac_float_type.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/isac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/structs.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_decoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/codecs/opus/include/audio_decoder_opus.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/opus/include/audio_encoder_opus.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/opus/include/opus_interface.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/interface/audio_decoder_opus.h View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/interface/opus_interface.h View 1 chunk +0 lines, -349 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_fec_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_interface.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_speed_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/include/pcm16b.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_send_test_oldapi.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_send_test_oldapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/nack.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/nack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/audio_coding_module.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/main/include/audio_coding_module.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/modules/audio_coding/main/include/audio_coding_module_typedefs.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 1 chunk +0 lines, -758 lines 0 comments Download
D webrtc/modules/audio_coding/main/interface/audio_coding_module_typedefs.h View 1 chunk +0 lines, -51 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/APITest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/Channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/EncodeDecodeTest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/EncodeDecodeTest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/RTPFile.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/SpatialAudio.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/TestAllCodecs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/TestRedFec.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/TestStereo.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/TestVADDTX.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/Tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/TwoWayCommunication.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/delay_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/iSACTest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/insert_packet_with_timing.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/opus_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/opus_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/target_delay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/utility.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/background_noise.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/decision_logic.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/neteq/include/neteq.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/interface/neteq.h View 1 chunk +0 lines, -288 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/rtcp.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/statistics_calculator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/RTPencode.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_isac_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/coder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_neteq_stats_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
kjellander_webrtc
This is part of standardizing where we put our "public API" headers so we can ...
5 years, 1 month ago (2015-10-29 07:12:16 UTC) #2
hlundin-webrtc
You forgot to rename all include guards for the relocated files. Fix that, and you ...
5 years, 1 month ago (2015-10-29 08:57:37 UTC) #3
kjellander_webrtc
Fixed now https://codereview.webrtc.org/1417173004/diff/1/webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h File webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h (right): https://codereview.webrtc.org/1417173004/diff/1/webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h#newcode11 webrtc/modules/audio_coding/codecs/ilbc/include/audio_decoder_ilbc.h:11: #ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_ILBC_INTERFACE_AUDIO_DECODER_ILBC_H_ On 2015/10/29 08:57:36, hlundin-webrtc wrote: ...
5 years, 1 month ago (2015-10-29 10:29:15 UTC) #4
kjellander_webrtc
TBR'ing tommi@ for: webrtc/call/call_perf_tests.cc webrtc/modules/utility/source/coder.h webrtc/voice_engine/channel.h webrtc/voice_engine/voe_base_impl.cc webrtc/voice_engine/voe_codec_impl.cc webrtc/voice_engine/voe_neteq_stats_impl.cc webrtc/voice_engine/voice_engine_impl.cc
5 years, 1 month ago (2015-10-29 10:30:27 UTC) #7
kjellander_webrtc
Committed patchset #3 (id:40001) manually as 74640895fafbb90a6630a6a91b80da0a7cff229c (presubmit successful).
5 years, 1 month ago (2015-10-29 10:31:17 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 10:31:18 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/74640895fafbb90a6630a6a91b80da0a7cff229c
Cr-Commit-Position: refs/heads/master@{#10444}

Powered by Google App Engine
This is Rietveld 408576698