Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1417093002: Adding the OnePlus 2 device to AEC and NS blacklists (Closed)

Created:
5 years, 2 months ago by henrika_webrtc
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding the OnePlus 2 device to AEC and NS blacklists. Reports show that we see full echo from the OnePlus 2 device. Disabling hardware effects and revert to WebRTC-based components instead as a test to see if it helps. R=tommi@webrtc.org TBR=tommi BUG=b/25096456 Committed: https://crrev.com/edcbd5610b56e88cc913ecc9ad0afb5c22a06eaa Cr-Commit-Position: refs/heads/master@{#10357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
henrika_webrtc
Tommi, could you please check this tiny CL. Thanks.
5 years, 2 months ago (2015-10-21 10:58:18 UTC) #3
henrika_webrtc
Very trivial, hence TBR tommi.
5 years, 2 months ago (2015-10-21 11:08:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417093002/1
5 years, 2 months ago (2015-10-21 11:08:13 UTC) #7
tommi
lgtm
5 years, 2 months ago (2015-10-21 11:39:23 UTC) #8
henrika_webrtc
Committed patchset #1 (id:1) manually as edcbd5610b56e88cc913ecc9ad0afb5c22a06eaa (presubmit successful).
5 years, 2 months ago (2015-10-21 11:44:01 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 11:44:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edcbd5610b56e88cc913ecc9ad0afb5c22a06eaa
Cr-Commit-Position: refs/heads/master@{#10357}

Powered by Google App Engine
This is Rietveld 408576698