Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1417063005: SurfaceViewRenderer: Drop old frames instead of new frames (Closed)

Created:
5 years, 1 month ago by magjed_webrtc
Modified:
5 years, 1 month ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

SurfaceViewRenderer: Drop old frames instead of new frames If SurfaceViewRenderer can't keep up with the stream of incoming frames it has to drop frames. Currently, new frames are dropped until the old pending frame is rendered. This CL drops the old pending frame instead. Committed: https://crrev.com/1ebf8ba3681b33b582766bceef922563614c1d47 Cr-Commit-Position: refs/heads/master@{#10558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
hbos - Please take a look.
5 years, 1 month ago (2015-10-30 15:31:43 UTC) #3
hbos
lgtm (red bots?)
5 years, 1 month ago (2015-11-02 09:36:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417063005/1
5 years, 1 month ago (2015-11-09 07:49:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 08:41:52 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 08:42:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ebf8ba3681b33b582766bceef922563614c1d47
Cr-Commit-Position: refs/heads/master@{#10558}

Powered by Google App Engine
This is Rietveld 408576698