Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1416873002: Testing that waiting for a condition variable waits. (Closed)

Created:
5 years, 2 months ago by hta-webrtc
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Andrew MacDonald, peah-webrtc, mflodman, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Testing that waiting for a condition variable waits. Added a test that verifies that waiting for a condition variable actually waits for a non-zero time. This used to fail due to a TSAN / CLANG bug, but this failure is supposed to have been fixed. This was originally https://webrtc-codereview.appspot.com/2145004 BUG=2259 Committed: https://crrev.com/3866c4fb460ebcf95857dbee6ec0e8664bd3b16a Cr-Commit-Position: refs/heads/master@{#10341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M webrtc/system_wrappers/source/condition_variable_unittest.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hta-webrtc
Another day, another codereview tool.
5 years, 2 months ago (2015-10-20 12:33:57 UTC) #3
tommi
lgtm
5 years, 2 months ago (2015-10-20 13:47:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416873002/1
5 years, 2 months ago (2015-10-20 13:47:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 2 months ago (2015-10-20 15:47:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416873002/1
5 years, 2 months ago (2015-10-20 16:10:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 16:31:04 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 16:31:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3866c4fb460ebcf95857dbee6ec0e8664bd3b16a
Cr-Commit-Position: refs/heads/master@{#10341}

Powered by Google App Engine
This is Rietveld 408576698