Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416783006: Register header extensions in RtpRtcpObserver to avoid log spam. (Closed)

Created:
5 years, 1 month ago by stefan-webrtc
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Register header extensions in RtpRtcpObserver to avoid log spam. BUG=webrtc:5118 R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/1295297153ff0487580faf821f24f09a7c16ce30

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M webrtc/test/call_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + webrtc/test/constants.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + webrtc/test/constants.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M webrtc/test/rtp_rtcp_observer.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M webrtc/test/webrtc_test_common.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416783006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416783006/1
5 years, 1 month ago (2015-10-29 12:09:01 UTC) #2
stefan-webrtc
5 years, 1 month ago (2015-10-29 12:09:03 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/10396)
5 years, 1 month ago (2015-10-29 12:17:16 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416783006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416783006/20001
5 years, 1 month ago (2015-10-29 12:33:57 UTC) #8
pbos-webrtc
lgtm
5 years, 1 month ago (2015-10-29 12:57:56 UTC) #10
stefan-webrtc
Committed patchset #2 (id:20001) manually as 1295297153ff0487580faf821f24f09a7c16ce30 (presubmit successful).
5 years, 1 month ago (2015-10-29 14:13:41 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 14:13:42 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1295297153ff0487580faf821f24f09a7c16ce30
Cr-Commit-Position: refs/heads/master@{#10450}

Powered by Google App Engine
This is Rietveld 408576698